ruuvi.firmware.c icon indicating copy to clipboard operation
ruuvi.firmware.c copied to clipboard

GPIO is not uninitialised on failed accelerometer initialisation, leaving floating pins

Open ojousima opened this issue 2 years ago • 4 comments

Possible fixes:

  • Uninit GPIO on failed init
  • Configure pull-up / down on GPIO

ojousima avatar Dec 12 '23 19:12 ojousima

How did you discover this?

DG12 avatar Dec 13 '23 00:12 DG12

I took off accelerometer with hot air and ran power profile

ojousima avatar Dec 13 '23 08:12 ojousima

What prompted you to do THAT ?

should this issue be in https://github.com/ruuvi/ruuvi.drivers.c ?

DG12 avatar Dec 13 '23 12:12 DG12

What prompted you to do THAT ?

We experiment on all kinds of things ;)

should this issue be in https://github.com/ruuvi/ruuvi.drivers.c

Not really. Drivers report back to application correctly that the accelerometer was not properly initialised, problem is in main.c/app_sensor.c and app_sensor_acc_thr_set()

ojousima avatar Dec 13 '23 14:12 ojousima