com.ruuvi.station.ios icon indicating copy to clipboard operation
com.ruuvi.station.ios copied to clipboard

Show alert limits in graphs

Open markoaamunkajo opened this issue 1 year ago • 5 comments

Description:

Show alert limits in graphs on history view page in app. Refer to WebUI card for details: https://github.com/ruuvi/com.ruuvi.station.webui/issues/204

Android card: https://github.com/ruuvi/com.ruuvi.station/issues/1063

markoaamunkajo avatar Jul 17 '23 08:07 markoaamunkajo

Currently not supported by library, needs internal discussion.

markoaamunkajo avatar Oct 17 '23 07:10 markoaamunkajo

@rinat-enikeev please investigate feasability for this on iOS after we have now had codebase improvements this could become important. Not high priority, take a look when you have time.

markoaamunkajo avatar Jan 18 '24 07:01 markoaamunkajo

more like investigation atm

rinat-enikeev avatar Jan 19 '24 07:01 rinat-enikeev

@rinat-enikeev looks like when I change units the alert limits will act weirdly. Build 2.7.0 (2403311418)

https://github.com/ruuvi/com.ruuvi.station.ios/assets/50437378/f3b9eebc-716d-42b6-90c2-c7676c648290

markoaamunkajo avatar Apr 11 '24 02:04 markoaamunkajo

@priyonto but still appears occasionally in UI.

Reproduced by flicking through cards when in history view mode. On one of the cards fill is broken. Also note that the middle chart has thinner line.

https://github.com/ruuvi/com.ruuvi.station.ios/assets/50437378/b00fb9f7-f952-4e79-bb59-14485fedf13f

Here are settings for those particular alerts on the card

Image

markoaamunkajo avatar May 10 '24 01:05 markoaamunkajo