Ruud Kamphuis comments

Results 363 comments of


                                            Ruud Kamphuis

Documentation for types tag uses Twig types in examples instead of PHP

Done: - https://github.com/phpstan/phpstan/pull/11882

verify that path used in twig actually exist

This can be done by creating a custom Node rule for Twig CS Fixer, see: https://github.com/VincentLanglet/Twig-CS-Fixer/blob/main/docs/custom.md#node-based-rules

Add PHP 8.4 to test matrix

@frederikbosch this one is ready for review.

Add PHP 8.4 to test matrix

@frederikbosch Oke, this one is ready. Had to make a few changes, hope you agree.

Add PHP 8.4 to test matrix

Done!

Add support for PHP 8.4.0

Duplicate of https://github.com/moneyphp/money/pull/796

Narrow return type of `$form->getData()` after calling `$form->isValid()`

But even if I would use an object instead of an array shape, there is still the problem of nullability. The nullability is needed for initial form state. For example,...

[PHP] - add support for PIE command

@vencakrecl Could you maybe create the PR?

Ability to fixup into the above commit

@stefanhaller Thanks for sharing. I learned 2 new things 🎉 I think it should be `r, up, enter` btw. Edit: You're right.

Ability to fixup into the above commit

I think the reason it's unintuitive is because the `[4] commits` window sorts it the other way around. That's what the user is looking at when hitting `r`. Therefore, I...