Ruud Kamphuis comments

Results 363 comments of


                                            Ruud Kamphuis

Add CommentNode to the AST

I was curious if there is a specific reason for not supporting comments in the Lexer? It seems a bit odd that these are simply skipped. While I agree that...

[AssetMapper][FrameworkBundle] Do not require `http_client` service

@carsonbot done

[AssetMapper][FrameworkBundle] Do not require `http_client` service

To me it's a bug and not a feature? It's not working without the service defined.

[Serializer] Cannot get base type on `int|string` compound type

@HypeMC This solves my problem too! Great work 🎉

[Serializer] Serializing empty class without properties serializes to `[]` when `preserve_empty_objects` is enabled

I have enabled the feature in the default context in the Framework: ```php 'serializer' => [ 'enabled' => true, 'name_converter' => 'serializer.name_converter.camel_case_to_snake_case', 'default_context' => [ AbstractObjectNormalizer::PRESERVE_EMPTY_OBJECTS => true, Serializer::EMPTY_ARRAY_AS_OBJECT =>...

[Serializer] Serializing empty class without properties serializes to `[]` when `preserve_empty_objects` is enabled

@HypeMC This does solve my issue indeed, thanks!

[Serializer] Serializing empty class without properties serializes to `[]` when `preserve_empty_objects` is enabled

@HypeMC It does solve the issue! 🎉

Better readability of error messages for unmatched ignore patterns

I agree. I think it would also help if unmatched ignored errors are presented differently than errors. Something like: :x: Found 2 errors :warning: 30 ignored errors from your baseline...

Better readability of error messages for unmatched ignore patterns

FWIW: I would recommend to disable erroring when ignored errors are no longer matching and refresh the baseline from time to time (tip: use a GitHub Actions cron). Especially on...

Type refinement for options in form types

Worked on a fixture that can be used to build this feature. It uses the [unsealed array shape syntax](https://github.com/phpstan/phpdoc-parser/pull/250) (that's not yet supported by PHPStan itself but [is on the...