ruthra kumar
ruthra kumar
> Send notifications to driver based on data that is only available or maintained on internal users Any example of an Internal User specific data?
Looks like a simple addition. Once the Framework changes are merged, then we can merge this as well.
@blaggacao If there are no items within the cut-off date, then a delivery note with empty items table is created. User can unintentionally create lot of junk delivery notes. [so_to_delivery_note.webm](https://github.com/frappe/erpnext/assets/3272205/c07085e2-60d0-4aad-b7e0-7781bf077d31)
Will take a look at it this week.
@blaggacao Code looks ok. No junk Delivery notes now. I think, making this a toggleable feature would be better. Add an option in `Selling Settings` and give the cut-off date...
semgrep failure is unrelated.Ignoring.
When backporting include https://github.com/frappe/erpnext/pull/40509
@mergify backport version-14
> @ruthra-kumar can you take this up? As long as the changes are small and easy to reason about, I can help with review. @blaggacao This PR is too big...
Let me know th PR's. I'll see if can revive them. If not, or if that too is complex/big, better to start afresh.