server icon indicating copy to clipboard operation
server copied to clipboard

Saving because it's bedtime. Not that this is remotly working

Open drazisil opened this issue 1 year ago • 4 comments

Summary by CodeRabbit

  • New Features

    • Introduced search functionality across various components to enhance user experience.
    • Added new database schemas for player, skin, vehicle, and warehouse management.
    • Implemented new database functions for car creation and part assembly transfer.
    • Enhanced gateway server initialization with database setup and error handling.
  • Enhancements

    • Upgraded multiple dependencies to improve performance and security.
    • Improved error handling and logging across services for better diagnostics.
    • Refined database operations with new imports and updated methods to ensure robust data handling.
  • Bug Fixes

    • Fixed issues with message handling and error logging in gateway services to ensure smoother operation.
  • Documentation

    • Updated script and configuration settings to align with new feature implementations and dependency updates.
  • Refactor

    • Refactored database and login services for improved performance and maintainability.
    • Simplified type annotations and method signatures in various modules to enhance code readability and efficiency.

drazisil avatar Apr 23 '24 00:04 drazisil

Walkthrough

The recent updates bring a wave of enhancements across the codebase, spanning Node version upgrades, dependency changes, new scripts and packages, refined database handling, improved gateway and transaction functionalities, and the introduction of novel database schemas and features for message processing and server communication. These alterations aim to elevate system capabilities, bolster reliability, and streamline operations.

Changes

File(s) Change Summary
.nvmrc, package.json Node version updated, dependencies upgraded, new scripts and packages added.
packages/cli/..., packages/connection/src/Connection.ts Introduces new classes and methods for handling console inputs, socket connections, and encryption functionalities.
packages/database/... Significant database updates including dependency additions, reorganized exports, and new functions and schemas.
packages/gateway/..., packages/transactions/... Enhanced gateway and transaction functionalities with improved logging, error handling, and database interactions.
schema/... Introduction of multiple new database schemas to manage diverse data types and structures effectively.
packages/mcots/..., packages/shared-packets/src/... Introduction of new features for message processing and server communication to enhance system capabilities.
apps/main/server.ts, packages/database/src/seeders/... Improved error handling, server initialization, and data seeding processes for enhanced system reliability and performance.
.github/codecov.yml, .github/workflows/node.yml, apps/main/package.json, build.mjs Updated configurations and build scripts for improved code coverage tracking, licensing information, and source map generation.

Poem

🐇✨ In the realm of code, where bits dance in glee, A rabbit weaves changes, swift and free. New scripts and schemas in the digital glen, Enhancing the system, beyond the ken. With a hop and a byte, the code evolves bright, A rabbit's touch, a coder's delight. 🌟🌿 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 23 '24 00:04 coderabbitai[bot]

Here's the code health analysis summary for commits 0129700..220ca19. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 416 occurences introduced
🎯 478 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

deepsource-io[bot] avatar Apr 23 '24 00:04 deepsource-io[bot]

Codecov Report

Attention: Patch coverage is 15.50875% with 3089 lines in your changes are missing coverage. Please review.

Project coverage is 32.37%. Comparing base (0129700) to head (220ca19).

:white_check_mark: All tests successful. No failed tests found.

Files Patch % Lines
packages/connection/src/Connection.ts 24.25% 281 Missing :warning:
packages/database/src/functions/createNewCar.ts 0.00% 242 Missing :warning:
packages/mcots/payloads/LoginCompleteMessage.ts 3.03% 224 Missing :warning:
packages/database/src/seeders/index.ts 0.00% 200 Missing :warning:
...ges/database/src/functions/transferPartAssembly.ts 0.00% 155 Missing :warning:
packages/database/src/seeders/populateWarehouse.ts 0.00% 124 Missing :warning:
packages/database/src/seeders/populateModel.ts 4.87% 117 Missing :warning:
packages/database/src/seeders/populateBrand.ts 5.00% 114 Missing :warning:
...ckages/database/src/seeders/populateBrandedPart.ts 5.35% 106 Missing :warning:
...es/database/src/functions/getWarehouseInventory.ts 14.87% 103 Missing :warning:
... and 43 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1909       +/-   ##
===========================================
- Coverage   42.42%   32.37%   -10.05%     
===========================================
  Files          83       96       +13     
  Lines       10351    10960      +609     
  Branches      190      174       -16     
===========================================
- Hits         4391     3548      -843     
- Misses       5960     7412     +1452     
Flag Coverage Δ *Carryforward flag
cli 11.44% <9.60%> (?)
connection 24.25% <24.25%> (?)
core 100.00% <ø> (ø)
database 7.84% <5.19%> (-6.38%) :arrow_down:
gateway 47.72% <21.19%> (+1.35%) :arrow_up: Carriedforward from 9bc4b76
lobby 22.49% <66.66%> (-10.21%) :arrow_down:
login 23.66% <46.15%> (-0.41%) :arrow_down:
mcots 25.50% <25.50%> (?)
patch 86.84% <100.00%> (-0.45%) :arrow_down:
persona 27.91% <0.00%> (-0.03%) :arrow_down: Carriedforward from 9bc4b76
shard 96.87% <ø> (ø)
shared 47.96% <33.12%> (?)
transactions ?

*This pull request uses carry forward flags. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 23 '24 00:04 codecov[bot]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@eslint/[email protected] None 0 14.3 kB eslintbot
npm/@fastify/[email protected] network Transitive: environment, eval +15 463 kB eomm
npm/@sentry/[email protected] environment, filesystem, network, shell, unsafe +4 7.03 MB sentry-bot
npm/@sentry/[email protected] environment, filesystem, network, shell, unsafe +8 7.83 MB sentry-bot
npm/@sentry/[email protected] environment, filesystem, shell +2 3.34 MB sentry-bot
npm/@types/[email protected] None +1 2.1 MB types
npm/@types/[email protected] None +10 289 kB types
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +56 13.3 MB dankochetov
npm/[email protected] None 0 5.5 MB dankochetov
npm/[email protected] Transitive: environment, eval, filesystem, unsafe +62 9.22 MB matteo.collina
npm/[email protected] Transitive: eval +1 925 kB scarney
npm/[email protected] environment, unsafe Transitive: eval, filesystem +22 1.88 MB jsumners
npm/[email protected] filesystem Transitive: environment +20 13.2 MB sdepold
npm/[email protected] None 0 148 kB jeanlescure
npm/[email protected] Transitive: filesystem, unsafe +2 509 kB hirokiosame
npm/[email protected] Transitive: environment, filesystem +45 8.24 MB jameshenry
npm/[email protected] None 0 628 kB colinmcd94

🚮 Removed packages: npm/@eslint/[email protected], npm/@sentry/[email protected], npm/@sentry/[email protected], npm/@slonik/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

socket-security[bot] avatar May 04 '24 01:05 socket-security[bot]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

socket-security[bot] avatar May 04 '24 01:05 socket-security[bot]

@SocketSecurity ignore npm/[email protected]

drazisil avatar May 04 '24 01:05 drazisil

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar May 09 '24 16:05 sonarqubecloud[bot]