rust-starter icon indicating copy to clipboard operation
rust-starter copied to clipboard

[Comment]:

Open OWissett opened this issue 2 years ago • 10 comments

What happened?

This isn't really a bug.

I wanted to drop a comment on your Medium article since you don't state that you need to run:

cargo install grcov

Without running this, you get a cryptic filesystem error. After digging around in the source files, I realised that I need the grcov tool. I suppose this likely is installed when you setup the package from this repo, however, I was adding test coverage to an existing large repo.

What type of Operating System?

Linux

Steps to produce this issue.

...

OWissett avatar Jan 24 '23 12:01 OWissett

I left this comment here, since I couldn't leave a comment on the article its self.

Might be worth a simple revision, since it is an essential step to get xtaskops working. Also you should probably say how to actually implement that function you give, since you don't use that implementation in this repo, but use xtaskops::tasks::main() to pull in all of the default ops tasks.

OWissett avatar Jan 24 '23 12:01 OWissett

Thanks! do you think adding an install through xtaskops is a good solution? Or just adding a verbal instruction?

jondot avatar Jan 24 '23 13:01 jondot

I think just verbal instruction

cargo install grcov

Also I think that you need to ensure that you have the coverage tooling installed for rustc:

rustup component add llvm-tools-preview

OWissett avatar Jan 24 '23 13:01 OWissett

I suppose that having it as a xtask job could be nice for this repo,

so that you can run cargo xtask init which installs all of the dev dependencies for this which aren't necessarily in the Cargo.toml

OWissett avatar Jan 24 '23 13:01 OWissett

You also need to install cargo-bloat, cargo-hack, and cargo-watch, maybe more too

OWissett avatar Jan 24 '23 13:01 OWissett

interesting, some of it is here: https://github.com/jondot/xtaskops/blob/master/xtaskops/src/tasks.rs#L245

jondot avatar Jan 24 '23 14:01 jondot

Ah cool.

I guess you just need grcov then and the llvm tools.

OWissett avatar Jan 24 '23 14:01 OWissett

perfect, thanks!

jondot avatar Jan 24 '23 14:01 jondot

PR: https://github.com/jondot/xtaskops/pull/3

OWissett avatar Jan 24 '23 14:01 OWissett

Thanks, just merged!

jondot avatar Jan 24 '23 16:01 jondot