wee_alloc icon indicating copy to clipboard operation
wee_alloc copied to clipboard

Is this repo still maintained?

Open corneliusroemer opened this issue 2 years ago • 8 comments

Summary

There's a pretty big bug #106 that sees a lot of projects switch away from using this crate. It hasn't received any comment or apparent attempt at fixing from anyone in the rust wasm org/team in 2 months.

Also, there has only been 1 commit in the last 3 years. Is this crate still maintained? It looks like @fitzgen is the original author and the other team members are @ZackPierce and @pepyakin.

Maybe the bug could be mentioned in the readme to raise awareness, so that people don't spend a lot of time debugging something that is not solvable.

What are alternatives for this crate?

This crate is quite popular at 2k daily downloads.

corneliusroemer avatar May 11 '22 09:05 corneliusroemer

I would like to know this too. I've been looking for alternatives but have been unable to find any good alternatives. Mimalloc doesn't work unless one uses emscripten https://github.com/purpleprotocol/mimalloc_rust/issues/76#issuecomment-1130098442=. I don't know of any other ones that could be used.

Titaniumtown avatar May 18 '22 14:05 Titaniumtown

I just wrote lol_alloc as an alternative to wee_alloc. Initially I tried to fix wee_alloc but I found it easier and more interesting to just make a new WASM allocator from scratch.

If you go and use lol_alloc, do not trust it: do some real testing before you trust it and report any issues. I have not used it in anything beyond a few minimal tests. Its quite likely full of worse bugs than wee_alloc has, but I'm confident I'll be able to fix them when found.

Craig-Macomber avatar Aug 09 '22 08:08 Craig-Macomber

Effectively, no, I don't think this repo is maintained. I contributed a bit several years ago with a side feature, but my present work has moved away from using this crate, and I haven't been able to pull together enough free time to mount a real attempt at facing down the serious bugs.

ZackPierce avatar Aug 30 '22 18:08 ZackPierce

Cool. We'll flag unmaintained on it at https://github.com/rustsec/advisory-db/issues/1394 to gently nudge any users .. just have to come up with a list of alternatives if possible other than the std one

@Craig-Macomber lol_alloc can be a honorable mention around research project around it :)

pinkforest avatar Aug 30 '22 19:08 pinkforest

Cool. We'll flag unmaintained on it at rustsec/advisory-db#1394 to gently nudge any users .. just have to come up with a list of alternatives if possible other than the std one

lol_alloc is the only alternative I know of other that std, at least for wasm32-unknown-unknown. I wrote it because I couldn't find anything else.

rustwasm/book still recommends using wee_alloc: https://github.com/rustwasm/book/search?q=wee_alloc&type=code

If someone wants to confirm those cases work with lol_alloc (I might someday, but not now) we might want to update them. Alternatively we could just have the book stick with std.

Craig-Macomber avatar Aug 30 '22 22:08 Craig-Macomber

I would like to know this too. I've been looking for alternatives but have been unable to find any good alternatives. Mimalloc doesn't work unless one uses emscripten purpleprotocol/mimalloc_rust#76 (comment). I don't know of any other ones that could be used.

I've now used lol_alloc without any issues for months now. Good work @Craig-Macomber

Titaniumtown avatar Mar 26 '23 03:03 Titaniumtown

Since no comments in this issue have mentioned it, another alternative allocator that may be of interest is talc (WASM README with light comparisons to lol_alloc and the default dlmalloc).

polarathene avatar Nov 21 '23 04:11 polarathene

Since no comments in this issue have mentioned it, another alternative allocator that may be of interest is talc (WASM README with light comparisons to lol_alloc and the default dlmalloc).

Thanks for the link. Not only does talc look like it fills the nitch of an actually good for general use but still smallish allocator, but also has much better perf data than I ever collected on lol_alloc myself. I may have to play with those benchmarks a bit.

Craig-Macomber avatar Nov 22 '23 06:11 Craig-Macomber