wasm-pack icon indicating copy to clipboard operation
wasm-pack copied to clipboard

fix: add the snippets directory by default

Open jdrouet opened this issue 10 months ago • 4 comments

This should fix https://github.com/rustwasm/wasm-pack/issues/1206

I don't know what is the way to detect if the snippets directory should be included so, by default, I include it considering it's already in the sideEffect section. Another possibility would be to add to the Cargo.toml metadata a package-json section that allows to add some files and enforce it there.

Tell me if it's ok with you or if you need some updates 😉

Make sure these boxes are checked! 📦✅

  • [x] You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • [x] You ran cargo fmt on the code base before submitting
  • [x] You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

jdrouet avatar Feb 27 '25 08:02 jdrouet

@jdrouet When do you think this PR would be merged? Do you have any idea of who we should reach out to about this?

LuisOsta avatar Jul 21 '25 23:07 LuisOsta

@drager @ashleygwilliams Is there something this PR needs before its ready to merge?

LuisOsta avatar Jul 21 '25 23:07 LuisOsta

Honestly, an approval from the maintainer 😁

jdrouet avatar Jul 22 '25 05:07 jdrouet

I tested this on my repo and verified that it worked for us FWIW

LuisOsta avatar Jul 22 '25 15:07 LuisOsta