wasm-pack
wasm-pack copied to clipboard
feat(webdriver): support geckodriver for `linux-aarch64`
Make sure these boxes are checked! 📦✅
- [x] You have the latest version of
rustfmt
installed
$ rustup component add rustfmt
- [x] You ran
cargo fmt
on the code base before submitting - [-] You reference which issue is being closed in the PR text
✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨
Introduces support to download Geckodriver in Linux aarch64
based on artifacts available
in Mozilla's releases: https://github.com/mozilla/geckodriver/releases.
Interesting, I changed geckodriver's code but chromedriver is failing here 🤔 https://github.com/rustwasm/wasm-pack/actions/runs/8069923360/job/22046060320?pr=1371#step:7:472
Okay, seems global: https://github.com/rustwasm/wasm-pack/actions/runs/8069923360/job/22046060320?pr=1371#step:7:469
The version fetched from https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json seems to be cached in tests environments, due to the fact that fetching such URL returns: "channel":"Stable","version":"122.0.6261.94","revision":"1250580"
while both tests in different PRs point to: chromedriver version: 122.0.6261.69
I just merged #1391. Can you rebase master into this branch? :)
I just merged #1391. Can you rebase master into this branch? :)
Hi! Sure!
Hi @drager! I think this is good to go now!