wasm-pack icon indicating copy to clipboard operation
wasm-pack copied to clipboard

feat(webdriver): support geckodriver for `linux-aarch64`

Open LeoBorai opened this issue 1 year ago • 3 comments

Make sure these boxes are checked! 📦✅

  • [x] You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • [x] You ran cargo fmt on the code base before submitting
  • [-] You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

Introduces support to download Geckodriver in Linux aarch64 based on artifacts available in Mozilla's releases: https://github.com/mozilla/geckodriver/releases.

LeoBorai avatar Feb 27 '24 18:02 LeoBorai

Interesting, I changed geckodriver's code but chromedriver is failing here 🤔 https://github.com/rustwasm/wasm-pack/actions/runs/8069923360/job/22046060320?pr=1371#step:7:472

LeoBorai avatar Feb 27 '24 19:02 LeoBorai

Okay, seems global: https://github.com/rustwasm/wasm-pack/actions/runs/8069923360/job/22046060320?pr=1371#step:7:469

LeoBorai avatar Feb 27 '24 19:02 LeoBorai

The version fetched from https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json seems to be cached in tests environments, due to the fact that fetching such URL returns: "channel":"Stable","version":"122.0.6261.94","revision":"1250580" while both tests in different PRs point to: chromedriver version: 122.0.6261.69

LeoBorai avatar Feb 27 '24 19:02 LeoBorai

I just merged #1391. Can you rebase master into this branch? :)

drager avatar Jun 25 '24 20:06 drager

I just merged #1391. Can you rebase master into this branch? :)

Hi! Sure!

LeoBorai avatar Jun 26 '24 01:06 LeoBorai

Hi @drager! I think this is good to go now!

LeoBorai avatar Jun 26 '24 01:06 LeoBorai