wasm-pack
wasm-pack copied to clipboard
feat: add `--no-modules-global` support
This PR adds pass-through support for the wasm-bindgen
flag --no-modules-global
, which is very useful when building/running WASM in certain scenarios (browser extensions in particular).
Supercedes #860 which was mysteriously closed last summer.
Closes #729.
Make sure these boxes are checked! 📦✅
- [x] You have the latest version of
rustfmt
installed
$ rustup component add rustfmt
- [x] You ran
cargo fmt
on the code base before submitting - [x] You reference which issue is being closed in the PR text
✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨
See also https://github.com/rustwasm/wasm-bindgen/issues/2700.
We are using this downstream and it's working well.
Hi there, any thoughts on this?
LGTM (as a random person on the internet with no approval/commit rights)
Hi there, it's been another month. Any thoughts?
LGTM
No clue, we've been using it for a while without issue.
I'd really like to have this feature as well, but apparently wasm-pack is lacking maintainers https://github.com/rustwasm/wasm-pack/issues/928
I wonder if I should use wasm-bindgen cli directly for this while waiting (?).