wasm-pack icon indicating copy to clipboard operation
wasm-pack copied to clipboard

feat: add `--no-modules-global` support

Open fosskers opened this issue 2 years ago • 6 comments

This PR adds pass-through support for the wasm-bindgen flag --no-modules-global, which is very useful when building/running WASM in certain scenarios (browser extensions in particular).

Supercedes #860 which was mysteriously closed last summer.

Closes #729.


Make sure these boxes are checked! 📦✅

  • [x] You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • [x] You ran cargo fmt on the code base before submitting
  • [x] You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

fosskers avatar Oct 20 '21 17:10 fosskers

See also https://github.com/rustwasm/wasm-bindgen/issues/2700.

fosskers avatar Oct 20 '21 17:10 fosskers

We are using this downstream and it's working well.

fosskers avatar Oct 22 '21 21:10 fosskers

Hi there, any thoughts on this?

fosskers avatar Dec 10 '21 16:12 fosskers

LGTM (as a random person on the internet with no approval/commit rights)

gthb avatar Dec 10 '21 18:12 gthb

Hi there, it's been another month. Any thoughts?

fosskers avatar Jan 20 '22 02:01 fosskers

LGTM

RonaldColyar avatar Jan 28 '22 09:01 RonaldColyar

No clue, we've been using it for a while without issue.

fosskers avatar Oct 03 '22 00:10 fosskers

I'd really like to have this feature as well, but apparently wasm-pack is lacking maintainers https://github.com/rustwasm/wasm-pack/issues/928

I wonder if I should use wasm-bindgen cli directly for this while waiting (?).

wlinna avatar Oct 14 '22 01:10 wlinna