wasm-pack icon indicating copy to clipboard operation
wasm-pack copied to clipboard

Migrate to 2018 edition and update dependencies

Open fkettelhoit opened this issue 4 years ago • 3 comments

This PR migrates to the 2018 edition and updates all dependencies in a way that no duplicate dependencies are pulled in, which resolves the issues #798 and #801.

Before the PR:

$ cargo tree --duplicates | wc -l
398

After:

$ cargo tree --duplicates | wc -l
0

Make sure these boxes are checked! 📦✅

  • [x] You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • [x] You ran cargo fmt on the code base before submitting
  • [x] You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

fkettelhoit avatar Aug 07 '21 12:08 fkettelhoit

@fkettelhoit Thanks a lot! I will go through this more closely in a while, I think this will be released in v0.11.0. Feel free to rebase master into your branch when you got time :blush:

drager avatar Aug 31 '21 15:08 drager

Migrate to edition 2021 may be another choice

bytesnail avatar Oct 16 '21 06:10 bytesnail

Any help needed with this?

saks avatar Sep 09 '22 21:09 saks