walrus icon indicating copy to clipboard operation
walrus copied to clipboard
verified publisher icon rustwasm

deps: update to [email protected]

Open guybedford opened this issue 1 year ago • 1 comments

Still a way to go, but it's progress.

Confirmed this resolves https://github.com/rustwasm/walrus/issues/261.

guybedford avatar Feb 28 '24 23:02 guybedford

I can also confirm that my code (an expanded version of #261) works with this PR - thank you for working on this fix!

juntyr avatar Mar 12 '24 11:03 juntyr

@guybedford Do you have an estimate for how long it might take to complete and merge this fix?

juntyr avatar Apr 17 '24 09:04 juntyr

@juntyr sorry I don't, it's hard to prioritise right now, but I will always try to make time for review here.

guybedford avatar Apr 19 '24 17:04 guybedford

0.21.0 is now released thanks to @lwshang in https://github.com/rustwasm/walrus/pull/266.

guybedford avatar Jul 02 '24 19:07 guybedford

With https://github.com/bytecodealliance/wasm-tools/pull/1628 (released in 0.212), wasm-encoder can now handle some mini-walrus usecases (e.g. tiny modifications on an existing wasm binary) - obviously walrus is still an excellent choice for anything more complex

juntyr avatar Jul 02 '24 19:07 juntyr

That looks really great. I also wonder if we could even reimplement the Walrus API around that reencoder model.

guybedford avatar Jul 03 '24 00:07 guybedford