twiggy
twiggy copied to clipboard
Add an '--all' flag to show all items.
Currently, we are working on adding logic to display summaries of truncated rows for different sub-commands in #88. This is nice because the number of items is displayed, but it would be nice if we had an --all
option to simply display all items, instead of something like --max-items $BIG_NUMBER
.
The top
sub-command would be a nice place to start, but this should eventually be done for all of the subcommands.
To Do:
- [x] diff
- [ ] dominators
- [x] garbage
- [x] monos
- [ ] paths
- [ ] top
@userzimmermann This might be a nice issue for you, if you're looking for other issues to work on here :smile_cat:
Definitely, @data-pup! I already created the branch for the PR... :)
Awesome! Let me know if you need any help, @fitzgen or I would be happy to provide some guidance if you get stuck :smiley_cat:
Don't worry ;) I'm still on it! But first had to deal w/ some confusion when running tests :D #116
Looks like this has been closed?
Looks like this has been closed?
The "To Do" checkboxes in the top comment accurately reflect the current state of play. There are a number of commands that don't have an --all
flag yet.
Heya all, I'd be willing to tackle this, but I'm new to this whole open source thing.
Also, for the top
command, it already has the maximum value for a u32
pub struct Top {
// ...
/// The maximum number of items to display.
#[structopt(short = "n", default_value = "4294967295")]
max_items: u32,
// ...
}
Would this be fine to keep or if we're adding the all option, should the default be set to something smaller? perhaps 20 like Diff
?