flakebox icon indicating copy to clipboard operation
flakebox copied to clipboard
verified publisher icon rustshop

feat: adding pkgs support for cross-compilation

Open SilentVoid13 opened this issue 1 year ago • 3 comments

closes #160.

This should not introduce any breaking changes, we can now pass a buildInputs and nativeBuildInputs lambda to craneMultiBuild that we get resolved in mkStdToolchains and ultimately passed to craneLib in mkFenixToolchain.

EDIT: I just realized my new commits were also forwarded to this PR, they basically add new targets (linux musl variants + windows64 with mingw).

SilentVoid13 avatar Jun 30 '24 11:06 SilentVoid13

We'll need tests in ./checks that make sure it works. But right now that craneArgs looks off to me.

dpc avatar Jul 01 '24 19:07 dpc

Got it, thanks for the review. I did not manage to get mergeArgs to work but I'm fairly new to writing nix

SilentVoid13 avatar Jul 01 '24 20:07 SilentVoid13

Hey @dpc, coming back to this PR

  • just pushed some tests for cross-compilation on new targets
  • suppressed cross pkgs for android targets since most packages look broken (e.g. openssl)
  • updated clang to version 17 since it looks like this is the version that is picked up now with clang-unwrapped

Tell me if there are still blockers to merge this

SilentVoid13 avatar Aug 23 '24 13:08 SilentVoid13