rustls icon indicating copy to clipboard operation
rustls copied to clipboard

`ResolvesServerCert::resolve` gets `ClientHello` by ref

Open ctz opened this issue 6 months ago • 2 comments

fixes #1908

ctz avatar Jun 13 '25 07:06 ctz

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 64334179 64536426 ⚠️ 202247 (0.31%) 0.28%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 64612793 64805274 ⚠️ 192481 (0.30%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 64615826 64756657 ⚠️ 140831 (0.22%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 48230845 48331394 ⚠️ 100549 (0.21%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11318115 11359205 41090 (0.36%) 1.15%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 49536707 49632479 95772 (0.19%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 64552540 64674191 121651 (0.19%) 0.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9480649 9495450 14801 (0.16%) 0.83%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 64439619 64341834 -97785 (-0.15%) 0.30%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 49555708 49625661 69953 (0.14%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 49507986 49568174 60188 (0.12%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 48275500 48226358 -49142 (-0.10%) 0.23%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 64334443 64277868 -56575 (-0.09%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11353218 11344543 -8675 (-0.08%) 1.56%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 64575973 64528857 -47116 (-0.07%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9489801 9496350 6549 (0.07%) 0.58%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3303088 3305269 2181 (0.07%) 0.29%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 64530917 64573468 42551 (0.07%) 0.39%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3109316 3107313 -2003 (-0.06%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 64412464 64373688 -38776 (-0.06%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 48174192 48146941 -27251 (-0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 49508025 49483920 -24105 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 64317796 64347923 30127 (0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 48331888 48352623 20735 (0.04%) 0.27%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10490302 10494654 4352 (0.04%) 0.99%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 48223797 48204057 -19740 (-0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4280819 4279093 -1726 (-0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1769036 1768326 -710 (-0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4277464 4275777 -1687 (-0.04%) 0.96%
handshake_session_id_1.2_no_crypto_server 1149454 1149034 -420 (-0.04%) 0.20%
handshake_tickets_1.2_no_crypto_server 1311468 1311048 -420 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 48173720 48188368 14648 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1766096 1765594 -502 (-0.03%) 1.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2674191 2674948 757 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2671320 2671985 665 (0.02%) 0.77%
handshake_tickets_1.3_no_crypto_server 2219795 2219375 -420 (-0.02%) 0.20%
handshake_session_id_1.3_no_crypto_server 2255945 2255525 -420 (-0.02%) 0.20%
handshake_no_resume_1.2_no_crypto_server 83931 83917 -14 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 64588915 64599309 10394 (0.02%) 0.20%
handshake_no_resume_1.3_no_crypto_server 102942 102928 -14 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3845567 3845147 -420 (-0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4253626 4253206 -420 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 49552472 49557278 4806 (0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4709200 4708780 -420 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4981454 4981034 -420 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296032 1295996 -36 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304043 3304115 72 (0.00%) 0.27%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 49577033 49576117 -916 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31877132 31876712 -420 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31878850 31878430 -420 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31878893 31878473 -420 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31999112 31998692 -420 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32000830 32000410 -420 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32000873 32000453 -420 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32334895 32334475 -420 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32336332 32335912 -420 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32336504 32336084 -420 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32437180 32436760 -420 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32438572 32438152 -420 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32438789 32438369 -420 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1294840 1294826 -14 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 64635169 64634482 -687 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3114892 3114921 29 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1718637 1718622 -15 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7218267 7218251 -16 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10996530 10996516 -14 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11124107 11124093 -14 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11129868 11129854 -14 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7220217 7220212 -5 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34735653 34735670 17 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45922140 45922129 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46005130 46005138 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80245480 80245469 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58034018 58034025 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58085103 58085110 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80249976 80249967 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46128682 46128687 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92604267 92604259 -8 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34733954 34733951 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58138120 58138125 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46166585 46166588 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92549276 92549270 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80346422 80346417 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80351501 80351496 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92608243 92608238 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58031043 58031040 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46009954 46009956 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46176966 46176968 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80240658 80240655 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58023192 58023190 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58142821 58142823 2 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104989082 104989079 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46171019 46171018 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92560104 92560102 -2 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105032246 105032248 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58148085 58148084 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92558407 92558408 1 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31061027 31061027 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31064378 31064378 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31068287 31068287 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2336815 2336815 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4264782 4264782 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4525863 4525863 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30741581 30741581 0 (0.00%) 0.20%
handshake_session_id_1.3_no_crypto_client 2199355 2199355 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30744490 30744490 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4197670 4197670 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92598273 92598273 0 (0.00%) 0.20%
handshake_tickets_1.3_no_crypto_client 2217924 2217924 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80357437 80357437 0 (0.00%) 0.20%
handshake_tickets_1.2_no_crypto_client 1271900 1271900 0 (0.00%) 0.20%
handshake_no_resume_1.3_no_crypto_client 112312 112312 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30836170 30836170 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31132637 31132637 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31139942 31139942 0 (0.00%) 0.20%
handshake_session_id_1.2_no_crypto_client 1176023 1176023 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30748688 30748688 0 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117370303 117370303 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2244143 2244143 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30833231 30833231 0 (0.00%) 0.20%
handshake_no_resume_1.2_no_crypto_client 99579 99579 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46015090 46015090 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2331164 2331164 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31136033 31136033 0 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117323109 117323109 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3857816 3857816 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57929080 57929080 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30840368 30840368 0 (0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.83 ms 1.77 ms ✅ -0.06 ms (-3.28%) 2.86%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_1.2_no_crypto 77.80 µs 80.67 µs 2.87 µs (3.68%) 5.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.28 ms 1.25 ms -0.03 ms (-2.70%) 4.70%
handshake_no_resume_1.3_no_crypto 86.90 µs 89.21 µs 2.31 µs (2.65%) 5.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.10 ms 1.07 ms -0.03 ms (-2.33%) 3.81%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.26 ms 1.24 ms -0.03 ms (-2.07%) 4.98%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.65 ms 1.62 ms -0.03 ms (-2.05%) 3.75%
handshake_tickets_1.2_no_crypto 393.81 µs 401.58 µs 7.78 µs (1.97%) 5.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.54 ms 4.61 ms 0.07 ms (1.58%) 7.55%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.22 ms 5.30 ms 0.07 ms (1.41%) 6.41%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.30 ms 5.37 ms 0.07 ms (1.33%) 6.37%
transfer_no_resume_ring_1.2_rsa_aes 5.72 ms 5.79 ms 0.07 ms (1.25%) 5.61%
handshake_no_resume_ring_1.3_ecdsap256_aes 458.27 µs 463.94 µs 5.67 µs (1.24%) 3.97%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 579.61 µs 586.70 µs 7.09 µs (1.22%) 3.94%
handshake_no_resume_ring_1.3_ecdsap256_chacha 455.47 µs 460.50 µs 5.03 µs (1.10%) 3.64%
transfer_no_resume_ring_1.3_rsa_aes 5.79 ms 5.86 ms 0.06 ms (1.09%) 5.77%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 577.75 µs 583.74 µs 5.99 µs (1.04%) 3.86%
handshake_session_id_1.2_no_crypto 363.38 µs 367.07 µs 3.69 µs (1.02%) 5.00%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.39 ms 8.46 ms 0.07 ms (0.86%) 4.18%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 8.46 ms 8.51 ms 0.06 ms (0.70%) 1.89%
handshake_tickets_1.3_no_crypto 652.28 µs 647.78 µs -4.50 µs (-0.69%) 5.00%
transfer_no_resume_1.2_no_crypto 11.81 ms 11.89 ms 0.08 ms (0.69%) 5.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 9.13 ms 9.19 ms 0.06 ms (0.66%) 1.79%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 8.63 ms 8.69 ms 0.06 ms (0.64%) 2.30%
handshake_session_id_ring_1.3_ecdsap256_aes 5.45 ms 5.48 ms 0.03 ms (0.64%) 1.37%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 8.41 ms 8.47 ms 0.05 ms (0.64%) 2.32%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 9.09 ms 9.14 ms 0.05 ms (0.59%) 1.86%
handshake_tickets_ring_1.2_rsa_aes 1.57 ms 1.58 ms 0.01 ms (0.57%) 1.21%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.23 ms 5.26 ms 0.03 ms (0.56%) 5.98%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 9.31 ms 9.37 ms 0.05 ms (0.55%) 1.85%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.01 ms 13.08 ms 0.07 ms (0.54%) 2.67%
handshake_session_id_ring_1.3_rsa_aes 5.95 ms 5.98 ms 0.03 ms (0.53%) 1.42%
transfer_no_resume_1.3_no_crypto 11.72 ms 11.78 ms 0.06 ms (0.53%) 5.00%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.85 ms 12.92 ms 0.07 ms (0.52%) 2.42%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.69 ms 13.76 ms 0.07 ms (0.51%) 2.60%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 8.60 ms 8.65 ms 0.04 ms (0.50%) 2.41%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 9.28 ms 9.32 ms 0.04 ms (0.44%) 2.39%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.03 ms 5.05 ms 0.02 ms (0.44%) 5.98%
transfer_no_resume_ring_1.3_rsa_chacha 13.36 ms 13.41 ms 0.05 ms (0.41%) 2.46%
handshake_no_resume_ring_1.2_rsa_aes 941.75 µs 945.63 µs 3.88 µs (0.41%) 1.58%
handshake_tickets_ring_1.3_ecdsap256_aes 5.52 ms 5.54 ms 0.02 ms (0.41%) 1.37%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.41 ms 5.43 ms 0.02 ms (0.40%) 1.74%
transfer_no_resume_ring_1.3_ecdsap384_chacha 15.95 ms 16.02 ms 0.06 ms (0.40%) 2.22%
handshake_session_id_1.3_no_crypto 668.55 µs 671.02 µs 2.48 µs (0.37%) 5.00%
handshake_no_resume_ring_1.3_rsa_chacha 948.20 µs 951.62 µs 3.42 µs (0.36%) 1.83%
handshake_session_id_ring_1.3_ecdsap384_aes 8.54 ms 8.57 ms 0.03 ms (0.35%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.26 ms 1.27 ms 0.00 ms (0.34%) 1.72%
handshake_session_id_ring_1.3_rsa_chacha 5.91 ms 5.93 ms 0.02 ms (0.32%) 1.60%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.25 ms 1.26 ms 0.00 ms (0.30%) 1.58%
handshake_tickets_ring_1.3_rsa_aes 6.01 ms 6.03 ms 0.02 ms (0.28%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.71 ms 13.74 ms 0.04 ms (0.28%) 2.27%
handshake_no_resume_ring_1.3_rsa_aes 948.66 µs 951.16 µs 2.50 µs (0.26%) 1.46%
handshake_tickets_ring_1.3_ecdsap384_aes 8.61 ms 8.63 ms 0.02 ms (0.25%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.48 ms 5.49 ms 0.01 ms (0.25%) 1.58%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 9.33 ms 9.35 ms 0.02 ms (0.24%) 2.53%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.51 ms 8.52 ms 0.02 ms (0.20%) 1.29%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.55 ms 3.56 ms 0.01 ms (0.20%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.57 ms 8.58 ms 0.01 ms (0.15%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 5.97 ms 5.98 ms 0.01 ms (0.14%) 1.31%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 9.14 ms 9.15 ms 0.01 ms (0.14%) 2.50%
handshake_session_id_ring_1.2_rsa_aes 1.50 ms 1.50 ms 0.00 ms (0.13%) 1.09%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 9.31 ms 9.32 ms 0.01 ms (0.12%) 2.50%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.55 ms 3.56 ms 0.00 ms (0.11%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 9.19 ms 9.19 ms 0.01 ms (0.07%) 2.19%

Additional information

Historical results

Checkout details:

  • Base repo: https://github.com/rustls/rustls.git
  • Base branch: dev-0.24 (4ec52b26923e257af4ff6203a15db15908e61313)
  • Candidate repo: https://github.com/rustls/rustls.git
  • Candidate branch: jbp-clienthello-resolveservercert (50658700f6cd7500933be8205a0337e5d7040d54)

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.39%. Comparing base (b9a530a) to head (5065870). Report is 5 commits behind head on dev-0.24.

Additional details and impacted files
@@             Coverage Diff              @@
##           dev-0.24    #2490      +/-   ##
============================================
- Coverage     95.40%   95.39%   -0.01%     
============================================
  Files            97       97              
  Lines         21874    21869       -5     
============================================
- Hits          20868    20863       -5     
  Misses         1006     1006              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 13 '25 07:06 codecov[bot]

Thanks a lot!

blind-oracle avatar Jun 19 '25 15:06 blind-oracle