hyper-rustls icon indicating copy to clipboard operation
hyper-rustls copied to clipboard

Allow construction with HttpConnector and default ClientConfig

Open inikulin opened this issue 5 years ago • 6 comments

Closes: https://github.com/ctz/hyper-rustls/issues/67

inikulin avatar Apr 01 '20 17:04 inikulin

Something is wrong with the CI for MacOS - builds get cancelled right away. It's definitely unrelated to the PR.

inikulin avatar Apr 02 '20 12:04 inikulin

maybe a new_with_connector() is more suitable.

https://github.com/hyperium/hyper-tls/blob/fa6d6a71a5b2be91c827a35f9fafe5179b0ff4ca/src/client.rs#L71-L75

kinosang avatar Aug 01 '20 16:08 kinosang

@kinosang thanks for the suggestion and we looked into it, but we'd like to stick with hyper-rustls in our project.

inikulin avatar Aug 02 '20 14:08 inikulin

@inikulin yeah, I mean, to uniformize the APIs, we may have a new_with_connector() for hyper-rustls instead of a default_client_config.

kinosang avatar Aug 02 '20 14:08 kinosang

This is what I did initially, however later we've had a case where we needed to do minor adjustments to the default config and this API is flexible enough to support that.

inikulin avatar Aug 02 '20 14:08 inikulin

@inikulin please rebase

@lucab @ctz could you have a look at this PR? I need exactly the same thing and this looks like an easy change.

ghost avatar May 31 '21 07:05 ghost