rusticata
ci: fix clippy findings, update cargo-check-external-types toolchain
👋 As promised, when cargo-check-external-types makes an update I'm opening PRs to fix the builds :-) This project also had several clippy findings that are fixed along the way.
See commit messages for individual explanations. I think adding a bitvec feature is the correct fix for the unexpected_cfgs finding, but this should be double checked.
I think adding a bitvec feature is the correct fix for the unexpected_cfgs finding, but this should be double checked.
Nope, that's no good. It seems like the code behind the feature gate requires the bitvec crate.
Probably the right fix is to add an optional = true dep for that crate and use the implicit feature it creates. I tried doing that with bitvec 1.x and there's a bunch of build errors. If I had to guess I'd say the code using this dep was written with an older version and the API has shifted. Unfortunately I don't have time to unwind this, maybe a maintainer could pick it up?
Or perhaps it should be removed since it was unused dead code until now?
I resolved the problem with the bitvec feature and merged your changes. Thanks!
