`scrypt error` rework

Open simonsan opened this issue 1 year ago • 1 comments

https://github.com/rustic-rs/rustic_core/blob/25f908b6b2d587e78bc156b53de40b91f7157458/crates/core/src/repofile/keyfile.rs#L109

Error needs own error code, with link to docs.

old restic versions used invalid scrypt parameters which are not (and I think will never be) supported by rustic

proposed workaround is to recreate the key in restic

Ref.: https://github.com/rustic-rs/rustic/issues/1394

Jan 06 '25 15:01 simonsan

As written in https://github.com/rustic-rs/rustic/issues/1394 I propose to wait with this until we get a decision from the Rust Crypto team about how they'll treat this. As there is already a RFC errata and this issue also occurs in e.g. etherium implementations, IMO there is a good chance this check will be relaxed in upstream and we won't see this error anymore in future.

Jan 07 '25 05:01 aawsome