rustic_core icon indicating copy to clipboard operation
rustic_core copied to clipboard

refactor!: use same paths representation for unix/windows

Open aawsome opened this issue 1 year ago • 3 comments

Use typed_path to use a common unix path representation on both windows/unix. This will increase windows compatibility and makes testing easier.

PR in rustic to integrate this change: https://github.com/rustic-rs/rustic/pull/1466

aawsome avatar Dec 24 '24 12:12 aawsome

Codecov Report

:x: Patch coverage is 52.78689% with 288 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 42.7%. Comparing base (64d052d) to head (5db575d). :warning: Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/chunker/rabin.rs 59.6% 42 Missing :warning:
crates/core/src/commands/check.rs 46.8% 42 Missing :warning:
crates/core/src/repofile/snapshotfile.rs 67.3% 33 Missing :warning:
crates/core/src/backend/local_destination.rs 0.0% 26 Missing :warning:
crates/core/src/commands/backup.rs 27.7% 26 Missing :warning:
crates/core/src/util.rs 36.8% 24 Missing :warning:
crates/core/src/blob/tree.rs 44.4% 15 Missing :warning:
crates/core/src/commands/restore.rs 0.0% 14 Missing :warning:
crates/core/src/repofile/configfile.rs 25.0% 12 Missing :warning:
crates/core/src/vfs.rs 42.8% 12 Missing :warning:
... and 13 more
Additional details and impacted files
Files with missing lines Coverage Δ
crates/core/src/archiver.rs 64.0% <100.0%> (+4.2%) :arrow_up:
crates/core/src/archiver/parent.rs 64.7% <100.0%> (-1.5%) :arrow_down:
crates/core/src/archiver/tree_archiver.rs 71.0% <100.0%> (+1.3%) :arrow_up:
crates/core/src/backend.rs 62.9% <100.0%> (+9.6%) :arrow_up:
crates/core/src/backend/childstdout.rs 66.6% <100.0%> (-6.7%) :arrow_down:
crates/core/src/commands/init.rs 93.7% <ø> (ø)
crates/core/src/repository/command_input.rs 64.8% <100.0%> (+2.8%) :arrow_up:
crates/core/tests/integration.rs 82.7% <100.0%> (-1.9%) :arrow_down:
crates/core/src/archiver/tree.rs 67.7% <93.3%> (+10.1%) :arrow_up:
crates/core/src/backend/ignore.rs 40.9% <88.8%> (-0.8%) :arrow_down:
... and 21 more

... and 23 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jan 13 '25 10:01 codecov[bot]

I manually rebased to newest main. @simonsan Can you please have a look at this PR? I think that a test on Windows is very much necessary here, but I don't own a windows system...

aawsome avatar May 23 '25 17:05 aawsome

waiting for https://github.com/BurntSushi/ripgrep/commit/79f5a5a66e68aa50ef9f63ded777e640d345df5e to be released in globset.

aawsome avatar Sep 20 '25 15:09 aawsome