ui-components icon indicating copy to clipboard operation
ui-components copied to clipboard

feat(question): add question component

Open kaseyvee opened this issue 1 year ago • 6 comments

Changes

  • add question component

Does not yet handle state persistence.

Screenshots

Screenshot 2024-05-23 at 11 49 56 AM Screenshot 2024-05-23 at 11 50 08 AM

desktop

Mobile

Screenshot 2024-05-23 at 11 50 36 AM

mobile

Dark mode

dark

kaseyvee avatar May 16 '24 19:05 kaseyvee

We are using all caps for the button text here. When on all other buttons we use lower case with the first letter being uppercase.

Laurendragonscale avatar May 17 '24 17:05 Laurendragonscale

Screenshot 2024-05-17 at 10 30 02 AM

The stacking of the words here is not great, I think the spacing is also off. I would suggest using a padding of 8px on the left and right sides.

Laurendragonscale avatar May 17 '24 17:05 Laurendragonscale

Use Text/Primary color style for the text inside the buttons and "divider" color style for the border

RenataDzotova avatar May 17 '24 17:05 RenataDzotova

I suggest changing button state to Secondary/Main for bg and Common/White for text when it's pressed

RenataDzotova avatar May 17 '24 17:05 RenataDzotova

Are you planning to handle loading the reply to the question component in the future? (User has already picked one answer and we are loading a chat history.)

lyjeileen avatar May 24 '24 17:05 lyjeileen

Are you planning to handle loading the reply to the question component in the future? (User has already picked one answer and we are loading a chat history.)

@lyjeileen @Shiti was thinking we could handle state persistence in the future once we've thought more about how we can pass threads/replies to components. So I think this will be relevant then, but not now.

kaseyvee avatar May 24 '24 18:05 kaseyvee