collision-rs icon indicating copy to clipboard operation
collision-rs copied to clipboard

Update to latest version of all dependencies

Open eira-fransham opened this issue 3 years ago • 6 comments

This change is Reviewable

eira-fransham avatar Jan 07 '21 09:01 eira-fransham

Code needs to be fixed, like CI errors indicate

kvark avatar Jan 07 '21 15:01 kvark

This branch compiles for me now locally, maybe the Travis build could be attempted again?

jameshiew avatar May 04 '21 18:05 jameshiew

bors r+

kvark avatar May 04 '21 19:05 kvark

Build failed:

bors[bot] avatar May 04 '21 19:05 bors[bot]

Errors still see legitimate?

14 | use genmesh::generators::{IndexedPolygon, SharedVertex, SphereUV};

   |                                                         ^^^^^^^^

   |                                                         |

   |                                                         no `SphereUV` in `generators`

   |                                                         help: a similar name exists in the module (notice the capitalization): `SphereUv`

kvark avatar May 04 '21 19:05 kvark

@Vurich I have rebased your changes and fixed the last build errors here Please take what you need to make this PR going.

The main issue was cgmath::Point3::from(mint::Vector), for some reason From/Into didn't want to co-operate. So I settled for a less effective: Point3::from(*v.pos.as_ref()), but at least It runs.

I will keep rebasing that branch for a while, keeping it updated with master

eadf avatar Sep 21 '21 21:09 eadf