llm icon indicating copy to clipboard operation
llm copied to clipboard

GGML README

Open danforbes opened this issue 2 years ago • 1 comments

Rendered document can be viewed here https://github.com/danforbes/llama-rs/blob/dfo/doc/ggml/crates/ggml/README.md

danforbes avatar May 14 '23 16:05 danforbes

I need help with (at least) vocabulary-scoring before this is ready to come out of draft.

danforbes avatar May 14 '23 20:05 danforbes

This is really well done! Awesome work, and sorry about not looking at it earlier!

Honestly, it's so thorough I'm wondering if I should encourage you to submit it to upstream GGML instead. They could certainly benefit from the documentation!

philpax avatar May 18 '23 13:05 philpax

Can you write one sentence that describes the purpose of token-scoring? Is this correct?

Depending on the GGML version, the token may also include a 32-bit floating point score, which impacts how likely that token is to appear in text generated by the model.

danforbes avatar May 20 '23 15:05 danforbes

Can you write one sentence that describes the purpose of token-scoring? Is this correct?

Depending on the GGML version, the token may also include a 32-bit floating point score, which impacts how likely that token is to appear in text generated by the model.

I'd say more "how likely that token is to appear in the dataset that the model was trained on", but otherwise yeah that's fine

philpax avatar May 20 '23 16:05 philpax

I'm ready for this to be merged if you are 👍🏻

danforbes avatar May 20 '23 17:05 danforbes

Honestly, it's so thorough I'm wondering if I should encourage you to submit it to upstream GGML instead. They could certainly benefit from the documentation!

Oh, that was always part of the plan 😉 https://github.com/ggerganov/ggml/pull/177

danforbes avatar May 20 '23 17:05 danforbes