erlang_nif-sys icon indicating copy to clipboard operation
erlang_nif-sys copied to clipboard

Erlang 22 support

Open JJJollyjim opened this issue 5 years ago • 7 comments

Erlang 22 is out (and in my case, my linux distro has updated), and with it comes NIF version 2.15. This means that NIFs won't build even with the latest erlang_nif-sys.

JJJollyjim avatar May 26 '19 13:05 JJJollyjim

What needs to be done to implement Erlang 22 support?

grahamhay avatar Jun 24 '19 22:06 grahamhay

Since I am not so involved in the project any more, I've sketched out the update process here.

goertzenator avatar Jun 24 '19 22:06 goertzenator

Any progress on this? A server went down when it received its automatic update as it wasn't able to rebuild the NIF's and so had to manually roll it back, which was not at all fun...

OvermindDL1 avatar Jul 15 '19 20:07 OvermindDL1

Support is on rustler master. erlang_nif_sys was vendored in there as erl_nif_sys, in which the changes have been made.

filmor avatar Jul 17 '19 11:07 filmor

@filmor Oh awesome, rustler is what I was needing, but any chance of PR'ing the changes back here for those that use this directly?

OvermindDL1 avatar Jul 17 '19 14:07 OvermindDL1

I don't think that would make much sense, seeing that further development will happen on the rustler repo. I'll have a look.

The PRs in question are https://github.com/rusterlium/rustler/pull/212 and https://github.com/rusterlium/rustler/pull/226.

filmor avatar Jul 17 '19 14:07 filmor

See #39.

filmor avatar Jul 21 '19 10:07 filmor