rustdesk icon indicating copy to clipboard operation
rustdesk copied to clipboard

Bad network condition on client side cause multi-typing

Open ddddavid-he opened this issue 2 years ago • 4 comments

Bug Description

When connecting to remote computer in unstable network connections, rustdesk will perform multiple strikes on a single keystroke during typing. (as shown in the screenshot below)

Screenshot_20240104_130702

How to Reproduce

type some word in unstable network connections

Expected Behavior

Type <ANYTHING> in client, do the same in remote.

Operating system(s) on local side and remote side

Windows 11 -> Debian 12 (KDE Plasma 5)

RustDesk Version(s) on local side and remote side

1.2.3 -> 1.2.4

Screenshots

Screenshot_20240104_130702

Additional Context

No response

ddddavid-he avatar Jan 04 '24 05:01 ddddavid-he

@fufesou to solve this (local press down, but immediate up event is sent to remote late because of network delay, remote linux will think it is a long press), we need send press event (up+down) for every non-modifier down event. To handle long-press, you need to have a timer to send multiple press until up event. But Windows / Osx / Linux have different long press behavior, I remember Windows generates multiple down events for long press, please confirm.

But this also has bad effect.

rustdesk avatar Jan 04 '24 06:01 rustdesk

Windows generates multiple down events for long press

Yes, it generates multiple down events.

fufesou avatar Jan 04 '24 07:01 fufesou

I have the same issue, but it only happens when I am typing into VMs on the computer that I am remoted into. The computer I am logging in with and logging in to are connected via ethernet and the rust server is self-hosted on the same computer that is hosting the VMs. This started when I upgraded to the latest version of the rust client.

PiratesIRC avatar Jan 05 '24 23:01 PiratesIRC

Hi @rustdesk Seeing that this is not taken up by anyone, could I take a crack at it ? not sure, how involved the changes would be, but I would be glad to be of some help. Thanks!

harshRn avatar Mar 12 '24 21:03 harshRn

@harshRn of course.

rustdesk avatar Mar 13 '24 01:03 rustdesk

When we type passwords, some characters are often entered twice or even more often.

Local OS: Windows 10 Pro 22H2 Remote OS: Debian 12

rustdesk avatar Jul 15 '24 06:07 rustdesk

The fix has been merged, please try out the latest nigthly build.

rustdesk avatar Jul 19 '24 23:07 rustdesk