rustdesk-server
rustdesk-server copied to clipboard
Fix: clippy warning in rust 1.62.1
Just resolve warnings in cargo clippy and build
$ rustc -V rustc 1.62.1 (e092d0b6b 2022-07-16)
@rustdesk PTAL
I just tried and every warning seems solved.
Just remember a touch of cargo fmt.
FYI on rust versions:
- ubuntu 20.04 uses rust 1.59.0
- ubuntu 22.04 uses rust 1.59.0
- our automatic build (via github actions) is ubuntu-22.04
So this is not urgent, but it's welcome.
LGTM
Of course I had ran cargo fmt
our automatic build (via github actions) is ubuntu-22.04
which now uses rust 1.62.1, as stated here
Now this PR is gaining priority.
@rustdesk PTAL
@dlhxzb sorry for ignoring this PR and introduced some conflicts. Could you help solve the conflicts?
Solved & update to 1.66.0
Great job!
@dlhxzb Thank you so much! do you have interest to fix clippy in rustdesk repo? We can do it part by part.
@rustdesk I will join a new company next month, so maybe a bit busy recently. I will do it if I have time
@dlhxzb Congratulations and Thanks. Take time, :)