rustdesk-server icon indicating copy to clipboard operation
rustdesk-server copied to clipboard

Fix: clippy warning in rust 1.62.1

Open dlhxzb opened this issue 3 years ago • 3 comments

Just resolve warnings in cargo clippy and build

$ rustc -V rustc 1.62.1 (e092d0b6b 2022-07-16)

@rustdesk PTAL

dlhxzb avatar Aug 02 '22 08:08 dlhxzb

I just tried and every warning seems solved. Just remember a touch of cargo fmt.

FYI on rust versions:

  • ubuntu 20.04 uses rust 1.59.0
  • ubuntu 22.04 uses rust 1.59.0
  • our automatic build (via github actions) is ubuntu-22.04

So this is not urgent, but it's welcome.

LGTM

paspo avatar Aug 05 '22 08:08 paspo

Of course I had ran cargo fmt

dlhxzb avatar Aug 08 '22 00:08 dlhxzb

our automatic build (via github actions) is ubuntu-22.04

which now uses rust 1.62.1, as stated here

Now this PR is gaining priority.

paspo avatar Aug 08 '22 17:08 paspo

@rustdesk PTAL

paspo avatar Nov 30 '22 08:11 paspo

@dlhxzb sorry for ignoring this PR and introduced some conflicts. Could you help solve the conflicts?

rustdesk avatar Jan 06 '23 03:01 rustdesk

Solved & update to 1.66.0

dlhxzb avatar Jan 06 '23 09:01 dlhxzb

Great job!

rustdesk avatar Jan 06 '23 12:01 rustdesk

@dlhxzb Thank you so much! do you have interest to fix clippy in rustdesk repo? We can do it part by part.

rustdesk avatar Jan 06 '23 16:01 rustdesk

@rustdesk I will join a new company next month, so maybe a bit busy recently. I will do it if I have time

dlhxzb avatar Jan 09 '23 08:01 dlhxzb

@dlhxzb Congratulations and Thanks. Take time, :)

rustdesk avatar Jan 09 '23 08:01 rustdesk