winit icon indicating copy to clipboard operation
winit copied to clipboard

Support is_x11 and is_wayland on EventLoop

Open dhardy opened this issue 1 year ago • 2 comments

  • [ ] Tested on all platforms changed
  • [x] Added an entry to the changelog module if knowledge of this change could be valuable to users
  • [ ] Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • [ ] Created or updated an example program if it would help users understand this functionality
  • [ ] Updated feature matrix, if new features were added or implemented

Winit v0.30 does not allow testing is_wayland on an EventLoop (but only on an ActiveEventLoop), though this appears to be possible. This is an issue for me.

The trait names ActiveEventLoopExtWayland and ActiveEventLoopExtX11 are now inaccurate (may cause issues with future additional functionality?), but this is the most straightforward solution.

Fixes https://github.com/rust-windowing/winit/issues/3670

dhardy avatar May 02 '24 08:05 dhardy

New traits then (a copy of these other than the name)?

dhardy avatar May 04 '24 13:05 dhardy

Yes. Which is unfortunate, but it will prevent errors if someone tries to add API for the EventLoop which requires EventLoop to be actually running.

kchibisov avatar May 04 '24 15:05 kchibisov