winit icon indicating copy to clipboard operation
winit copied to clipboard

Use `super` instead of `platform_impl::platform` in paths

Open madsmtm opened this issue 1 year ago • 2 comments

Makes it easier to do refactors later on

madsmtm avatar Aug 11 '22 11:08 madsmtm

Honestly, I really don't like super path for modules. It's not that clear where things are coming from, etc. They are not that readable and prone to errors when you move files around (e.g. when you move something to a module).

kchibisov avatar Aug 11 '22 12:08 kchibisov

I agree somewhat, for example I didn't change this on the wayland platform, since it would mean doing super::super::super. But I think crate::platform_impl::platform is just ugly and confusing (since there's not actually a platform module in platform_impl, it's just an implementation detail of how platform_impl works).

Motivation was because I'd like to change these paths in the future, and it would mean a smaller diff when that time comes.

madsmtm avatar Aug 11 '22 14:08 madsmtm

I don't like super in general.

kchibisov avatar Feb 27 '24 20:02 kchibisov