rust-windowing
Allow changing resize increments after window creation
Pretty basic "I hope it works" implementation, only tested on X11, can test on a mac in a few days.
Once this is reviewed->merged->released I hope to finally make Alacritty not suck, heh
~The branch is based on the #2410 because I kept moving the test window to the other screen, I'll rebase once it's merged,~ done
Currently this is a draft to run your CI and to get reviews.
Closes #2020
- [x] Tested on all platforms changed
- [x] Added an entry to
CHANGELOG.mdif knowledge of this change could be valuable to users - [x] Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
- [x] Created or updated an example program if it would help users understand this functionality
- [x] Updated feature matrix, if new features were added or implemented
Still marked as a draft because I did not test this on a mac yet, if you have a mac and are willing to test this you are welcome
Ok so I guess @madsmtm tested this on a mac so I'm undrafting this. A couple of remaining minor reviews waiting for clarification after my comment and contentResizeIncrements/resizeIncrements debate also waits for a quorum agreement I guess
Hey @kchibisov have you had a chance to see my reply to your comments about logging on unsupported platforms?
Do you insist on adding those logs or does my reasoning make sense to keep it as I did it initially
@necauqua the thing is that log was added after some point in time, so the platforms inherited // not supported comments and there wasn't anything to change that. In general we want to log, but for now we can leave it as is for consistency sake.
Ok then
Maybe later some separate effort should be put in to update all these comments with log warnings (I'd personally also add a feature to disable that? or better a special log target(s) for those 'not implemented/unsupported' warnings)