winit icon indicating copy to clipboard operation
winit copied to clipboard

examples/window: use softbuffer

Open dhardy opened this issue 3 years ago • 5 comments

See also #2350, https://github.com/john01dav/softbuffer/pull/20.

  • [ ] Tested on all platforms changed
  • [ ] Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • [ ] Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • [ ] Created or updated an example program if it would help users understand this functionality
  • [ ] Updated feature matrix, if new features were added or implemented

dhardy avatar Jul 01 '22 12:07 dhardy

The X11-only CI appears to be failing due to a somehow missing waland-client system library. Not sure what's up with that.

maroider avatar Jul 03 '22 06:07 maroider

softbuffer has this dependency:

wayland-client = {version = "0.29", features = ["use_system_lib"], default_features = false}

I tried adding libwayland-client0 as a dependency... though since winit itself already uses wayland-client with this feature I'm doubtful.

dhardy avatar Jul 03 '22 07:07 dhardy

No surprise, that didn't help:

libwayland-client0 is already the newest version (1.18.0-1).

Strangely, its the x11 build that failed.

Running cargo test --no-run --verbose --target x86_64-unknown-linux-gnu --no-default-features --features x11 (what the command reduces to) on my machine (running X11) works.

dhardy avatar Jul 03 '22 07:07 dhardy

Strangely, its the x11 build that failed.

Indeed. It's quite strange. Could it be that there's some side-effect softbuffer inadvertently relies on when we enable our Wayland deps? I'm not sure if this is particularly likely, but the X11-only build does seem to be the only Linux build consistently failing.

maroider avatar Jul 03 '22 07:07 maroider

Personally I'd be a little skeptical of using softbuffer as an example as it has some bugs on Wayland. And there is also the maintenance issue as several issues and pull requests have been opened in the last 2 months without any responses.

I do recall we had a winit-blit project, but that never really took off.

i509VCB avatar Jul 04 '22 00:07 i509VCB

We've forked swbuf under @rust-windowing, so we'll probably want to use that instead - I'll close this for now, esp. also because swbuf doesn't support all of winit's platforms yet (Android and iOS missing), but free to reopen if you update it to use that

madsmtm avatar Dec 21 '22 17:12 madsmtm

Good to hear that there's a maintained fork. If you'd rather see swbuf support more platforms first then I guess there's no point updating this PR for now.

dhardy avatar Dec 22 '22 10:12 dhardy