keyboard-types icon indicating copy to clipboard operation
keyboard-types copied to clipboard

Consider maintaining this under the @rust-windowing organization?

Open madsmtm opened this issue 11 months ago • 2 comments

I'm finding lately that there is renewed interest in the ecosystem for having a shared set of crates for windowing types and events (see https://github.com/rust-windowing/winit/issues/2394 and https://github.com/rust-windowing/winit/issues/3433 for a bit of previous discussion, although this is by far not specific to Winit).

I believe that keyboard-types is an excellent candidate for being part of that set, and thus I would like to propose moving it to the @rust-windowing GitHub organization.

Pros:

  • Reduced bus factor.
  • Increased visibility.
  • Increased pool of maintainers (if wanted).

Cons:

  • Might end up tying this more to Winit's needs than desirable/necessary.
  • Could be seen as a "takeover" of the crate[^1].

Note that I do not believe that this is a blocker for using keyboard-types in Winit (can wait 'till after https://github.com/rust-windowing/winit/pull/4026 lands if you'd prefer that), but it would still be really nice for us to know that we can make modifications to the crate in the future, even if you disappear.

Other possibilities include the @linebender and @servo organizations, though I believe that the @rust-windowing organization would be a better fit for this crate, as it already hosts various other interoperability crates such as cursor-icon (also based on a W3C spec), raw-window-handle and dpi (and I'm considering adding one for pointer events).

What do you think @pyfisch? To be clear, you'd still retain publish rights and the repo itself would still be your responsibility to maintain however you see fit (including being the one with merge rights + having final say in any decision making).

[^1]: Ugh, I hate writing these kinds of issues, since I never know how to write what I think without being rude, it's hard to accurately state your intentions, and the textual medium is a lot more finicky than a real-life conversation. Please do not take this badly, and I apologize in advance if I've offended you!

madsmtm avatar Feb 13 '25 20:02 madsmtm

I am open to moving the crate to @rust-windowing. Ideally the move should coincide with winit using this crate to ensure that the crate is useful to winit and the pool of maintainers actually increases.

pyfisch avatar Mar 09 '25 11:03 pyfisch

Cool! I've sent you an invitation to the org, feel free to do the transfer when you feel like it:

(I'll try to move forwards with the Winit work in the meantime).

madsmtm avatar Mar 09 '25 14:03 madsmtm

https://github.com/rust-windowing/winit/pull/4026 is ready and approved, and I believe keyboard-types is ready to be used in Winit now (once the next version is released, at least).

madsmtm avatar Mar 23 '25 12:03 madsmtm

Hey @pyfisch, have you had time to do this yet? How could I help move it forwards?

madsmtm avatar Apr 20 '25 05:04 madsmtm

I have transferred the crate to @rust-windowing and invited @madsmtm and @kchibisov as co-owners on crates.io.

pyfisch avatar Apr 21 '25 07:04 pyfisch

Excellent! I've added the GitHub team to the crate as well, thanks a lot for your consideration!

madsmtm avatar Apr 21 '25 09:04 madsmtm