keyboard-types icon indicating copy to clipboard operation
keyboard-types copied to clipboard
Published 4 weeks ago • verified publisher icon rust-windowing

Mark legacy modifier keys and codes as deprecated

Open madsmtm opened this issue 1 year ago • 4 comments

This resolves my concern with Meta vs. Super from https://github.com/pyfisch/keyboard-types/issues/19.

madsmtm avatar Dec 01 '24 13:12 madsmtm

Please rebase the PR.

pyfisch avatar Dec 22 '24 13:12 pyfisch

Rebased now.

madsmtm avatar Feb 13 '25 17:02 madsmtm

Weird, KeyCode::Cut, KeyCode::Find, etc. seems like they're actually emitted by Winit? TODO: What does Chrome/Firefox emit on Web if you click these keys?

madsmtm avatar Mar 07 '25 16:03 madsmtm

Weird, KeyCode::Cut, KeyCode::Find, etc. seems like they're actually emitted by Winit? TODO: What does Chrome/Firefox emit on Web if you click these keys?

Looking at Chromium's source code, it's clear that they do emit these key codes. So I've un-marked them as deprecated for now, and made this PR only focus on the deprecated modifier keys (since that will be confusing when upgrading Winit).

madsmtm avatar Mar 10 '25 12:03 madsmtm