glutin icon indicating copy to clipboard operation
glutin copied to clipboard

Fix logic in egl Device::query_device

Open quaternic opened this issue 8 months ago • 3 comments

The previous test would mistakenly return an error if the extensions contain "EGL_EXT_device_base" but not the two others. As stated by the comment, and in https://registry.khronos.org/EGL/extensions/EXT/EGL_EXT_device_base.txt , it is supposed to contain the other two.

The cases that should not return an error are:

  • contains EGL_EXT_device_base (B)
  • contains both EGL_EXT_device_enumeration (E) and EGL_EXT_device_query (Q)

The overall effects of this patch in terms of those three extensions are:

  • !B & E & !Q leads to a different error message than before
  • B & !E & !Q no longer errors
  • !B & E & Q no longer errors

quaternic avatar Jul 01 '24 19:07 quaternic