glutin icon indicating copy to clipboard operation
glutin copied to clipboard

Published 20 hours ago • verified publisher icon rust-windowing

Move to `objc2`

Open madsmtm opened this issue 1 year ago • 6 comments

Helps with following Cocoa's memory management rules (for example, https://github.com/rust-windowing/glutin/pull/1453 wouldn't have happened with this) - and while I was at it, I fixed a few C enum definitions (objc2's verify_message feature is a great help with that).

See commit messages for details.

  • [x] Tested on all platforms changed
  • [x] Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • [x] Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • [x] Created or updated an example program if it would help users understand this functionality

madsmtm avatar Sep 09 '22 02:09 madsmtm

Ah, you'd need a CI update for that? Could you also rebase?

kchibisov avatar Sep 09 '22 18:09 kchibisov

I moved the required MSRV bump to https://github.com/rust-windowing/glutin/pull/1464

madsmtm avatar Sep 09 '22 18:09 madsmtm

Will rebase after https://github.com/rust-windowing/glutin/pull/1465 probably

madsmtm avatar Sep 11 '22 19:09 madsmtm

I'm not sure how I should go forward with it, since the change is more or less stylistic right now. I'd wait for objc2 to release first. Don't want to release anything glutin with unstable crates.

kchibisov avatar Oct 04 '22 07:10 kchibisov

Fair - but then you should probably merge https://github.com/rust-windowing/glutin/pull/1474 (otherwise glutin doesn't compile on macOS aarch64)

madsmtm avatar Oct 04 '22 12:10 madsmtm

~I think it's aliased to 0 anyway?~

Ah, I see, can't reopen though, should resend PR.

kchibisov avatar Oct 04 '22 13:10 kchibisov