vhost-device icon indicating copy to clipboard operation
vhost-device copied to clipboard

Fix typos and broken link in README.md

Open sumbal008 opened this issue 2 years ago • 2 comments

Summary of the PR

The link to vhost_user frontend crate is broken and gives 404 error. This PR fixes the broken link and minor typos in the documentation.

Requirements

Before submitting your PR, please make sure you addressed the following requirements:

  • [ ] All commits in this PR are signed (with git commit -s), and the commit message has max 60 characters for the summary and max 75 characters for each description line.
  • [ ] All added/changed functionality has a corresponding unit/integration test.
  • [ ] All added/changed public-facing functionality has entries in the "Upcoming Release" section of CHANGELOG.md (if no such section exists, please create one).
  • [ ] Any newly added unsafe code is properly documented.

sumbal008 avatar Oct 28 '23 20:10 sumbal008

Not sure why the DCO check is failing here?

stsquad avatar Oct 29 '23 18:10 stsquad

Not sure why the DCO check is failing here?

Because author and signed-off don't match.

commit d2e15c20dc0cc61f46e34289a6d4a78ef570bb6d (temp/fix-documentation-typos-and-link) Author: sumbal008 [email protected] Date: Sun Oct 29 00:10:20 2023 +0500

Fix typos and broken link in README.md

The link to vhost_user frontend crate and typos in the documentation are fixed

Signed-off-by: Sumbal Tariq <[email protected]>

@sumbal008 Please fix your Author email id.

vireshk avatar Oct 30 '23 02:10 vireshk