too-many-lists

too-many-lists copied to clipboard

This example demonstrates that without iterative drop implementation, dropping a long list will cause stack overflow.

jerrylususu

I believe this is a typo, except you guys were referring to this very random website I found through googling "deinvent vs reinvent": [De-invent don't re-invent!](https://www.wisdomandwonder.com/article/9105/de-invent-dont-re-invent)

hexaron

In my case, I had to search the definition of mem::replace in the rust documentation for knowing what it does and understanding why this example works. I think that an...

Pablito2020

Names of links didn't match up to what they were pointing at, had a "TODO" where it really wasn't needed anymore?

saxxie-dev

For [Section 2.5](https://rust-unofficial.github.io/too-many-lists/first-pop.html), wouldn't it be better to use the `todo!` macro in each of the cases: ```rust pub fn pop(&mut self) -> Option { match self.head { Link::Empty =>...

Chris00

Add a test to check stack overflow in "fist-drop" section

3

I think it is great to add a test to [this section](https://rust-unofficial.github.io/too-many-lists/first-drop.html) to cause stack overflow before implementing our own `Drop`.

tamuhey

- Mentionning real-time queue - typo

Arthur-Milchior

There is no need to capitalize after colon. (https://www.grammarbook.com/blog/commas/capitalization-with-colons/) It leads to think it is about the List A and not just a list. Thank you!

nicarran

Reading about queue, and your sentence mentionning that it would require traversing the sequence of nodes, I felt slightly bad. I love Okasaki's work and feel like honesty requires to...

Arthur-Milchior

Arthur-Milchior