rust-skia icon indicating copy to clipboard operation
rust-skia copied to clipboard

Milestone 126

Open pragmatrix opened this issue 1 year ago • 0 comments

This PR aligns rust-skia with Skia's chrome/m126 branch.

  • [x] Update README.md (rendered)

    Most important here is to change the Skia branch name and the current Skia submodule tag at the top of the README.md file.

  • [ ] Diff the the following files to see if the build organization has changed significantly:
    • [ ] /BUILD.gn
    • [ ] /gn/* (recursively)
    • [ ] /modules/skshaper/BUILD.gn
    • [ ] /modules/skshaper/skshaper.gni
    • [ ] /modules/paragraph/BUILD.gn
    • [ ] /modules/paragraph/skparagraph.gni
  • [x] Skia builds (release notes).
  • [x] /skia-bindings builds.
  • [ ] /skia-safe: Update & add new wrappers by diffing include files.

    Add TODOs for everything that can not be updated right now, and attempt to stay compatible with previous versions of skia-safe without trying too hard before version 1.0. Use deprecated attributes if needed.

    • [ ] codec/
    • [ ] core/
    • [ ] docs/
    • [ ] effects/
    • [ ] encode/
    • [ ] gpu/
      • [ ] d3d/
      • [ ] ganesh/
      • [ ] gl/
      • [ ] mtl/
      • [ ] vk/
    • [ ] pathops/
    • [ ] svg/
    • [ ] utils/
    • [ ] modules/
      • [ ] paragraph/
      • [ ] shaper/
    • [ ] private/base/*
      • [ ] SkPoint_impl.h
  • [ ] Review Send & Sync implementations for new wrappers.
  • [ ] Review Debug implementation for new wrapper types and functions.
  • [ ] Release date of the matching Chrome version in less than 7 days?
  • [ ] Any pending changes in the Skia chrome/m126 branch that aren't synchronized yet?
  • [ ] Rebase on or merge with master.
  • [ ] Do the rust-skia: commits in the skia-bindings/skia subdirectory match with master (make diff-skia).
  • [ ] Update versions of skia-bindings/Cargo.toml and skia-safe/Cargo.toml and also add the version to the new deprecated attributes.
  • [ ] Do the tags/hashes in skia-bindings/Cargo.toml under [package.metadata] match the submodules depot_tools and skia?
  • [ ] Review API changes: make diff-api.
  • [ ] Test builds we don't do on the CI:
    • [ ] Compiles to Catalyst targets on macOS (#548).
      make macos-qa
      
  • [ ] Do one final review of all the changes.
  • [ ] Run make doc and fix all warnings.

pragmatrix avatar May 15 '24 19:05 pragmatrix