sailfish
sailfish copied to clipboard
rust-sailfish
Sailfish website is down
All I get is Not Found - Request ID: 01FWD26WY2GVBF6SFW1ETY4CXC when I go to the Sailfish website.
...on a related note, have you considered hosting it using GitHub Pages?
We consider migrating to GitHub Pages. This could be done by using Python container and running scripts/build-docs.py.
@ssokolow What's the URL you are using? I know there's been some work on this.
I was using https://sailfish.netlify.app/ and pages below that, as was linked from https://github.com/rust-sailfish/sailfish at the time and is still linked from https://crates.io/crates/sailfish and https://lib.rs/crates/sailfish
I would add that the same URL is also still linked from https://docs.rs/sailfish/latest/sailfish/.
Wow! Thank you both for your helpful input! I will work on cleaning those up.
Besides that, the documentation URL changed to https://rust-sailfish.github.io/sailfish/ Maybe I should change it in the code documentation.
@ssokolow @Anders429 Can you verify that the links are correct now? If so, this can be closed.
I can confirm that the documentation link I mentioned above is correct. The link in the README (which I believe is the one @ssokolow was referring to in the links they mentioned) seems to be fine too.
The "User Guide" link just under the badges in the README still points to https://rust-sailfish.netlify.app/en/ on https://lib.rs/crates/sailfish and https://crates.io/crates/sailfish and https://github.com/rust-sailfish/sailfish
Also, I don't know why, but the "GutHub (rust-sailfish)" tab at https://lib.rs/crates/sailfish is pointing at https://github.com/rust-sailfish/sailfish/tree/HEAD/sailfish rather than https://github.com/rust-sailfish/sailfish
I was assuming that the rust-sailfish.netlify.app url was fine because the website appears to be back online.
Based on past experience, keeping it up has a worse bus factor than using GitHub Pages and it doesn't make sense to have some links pointing to https://rust-sailfish.github.io/sailfish/ and others pointing to netlify.
@Anders429 Thank you for your comment! I'm still figuring this out. @ssokolow That's a very good point! Sticking to GitHub pages only would be probably a good path forward. Any concerns, or comments, @Kogia-sima @jdrouet ?
If you decide to go with GitHub pages, I suggest setting up a redirect from the old website to accommodate old links that may exist around the web. At least temporarily.
@Anders429 @ssokolow @jdrouet Was there any pages left that have this problem? I think I got them all thanks to some help from the community! :+1:
Also, I was thinking of wanting to change the comment type to be the same type as <!-- _Comment_goes_here --> because CTRL+K CTRL+C comments the .stpl file from VSCode. What does everyone think? @ssokolow @jdrouet @Kogia-sima @Anders429
Was there any pages left that have this problem? I think I got them all thanks to some help from the community!
The "User Guide" link at the top of the README is still pointing at https://rust-sailfish.netlify.app/en/
Also, I was thinking of wanting to change the comment type to be the same type as because CTRL+K CTRL+C comments the .stpl file from VSCode. What does everyone think?
Could you rephrase that? I'm not sure what you mean.
@ssokolow Please see the updated comment, I meant follow the HTML commenting style. I guess I accidentally commented that part out. :laughing:
Also, I was thinking of wanting to change the comment type to be the same type as
<!-- _Comment_goes_here -->because CTRL+K CTRL+C comments the .stpl file from VSCode. What does everyone think?
How would that work if e.g users want to output an actual HTML comment? Sailfish comments serves as a way to comment the template, while HTML comments serves as a way to comment the rendered markup imo.
Maybe it's possible to update the sailfish vscode plugin to insert a sailfish comment rather than an HTML comment when that action is executed?
@vthg2themax Generally, I prefer the Salfish comments to the HTML ones for two reasons:
- I prefer to send as little as possible over the wire for resource-efficiency reasons, and Sailfish comments aren't injected into the rendered output. (This is relevant both for textual comments and for commented-out chunks of code.)
- Using Sailfish comments means that, for something I haven't open-sourced (yet), I don't have to stop to think about whether I'm ready to share the details in the comment yet.
In fact, point number one, combined with the improved compile-time correctness is why, if you're ignoring performance, markup.rs has a competitive advantage and why I'm pondering whether I have time to write a preprocessor so I can write in that syntax and and have it translated to Sailfish templates. (Heck, given that Sailfish breaks #![forbid(unsafe_code)] for my own code unless I shove my templates off into a separate crate, I'm also pondering whether I need the amount of performance Sailfish offers.)
@Svenskunganka @ssokolow If even one user would be negatively impacted, I shall not make the change then. Thank you for your feedback! I will leave things as they are as regarding to comments in Sailfish.
On a separate note: I think I will close this in a week if there are no other spots that have bad references to the site. Please let me know if you find anything else. @Anders429 @jdrouet