ndarray icon indicating copy to clipboard operation
ndarray copied to clipboard

Published 20 hours ago • verified publisher icon rust-ndarray

Simplify `s![]`

Open CAD97 opened this issue 3 years ago • 1 comments
trafficstars

Fixes #1194 with a very slight generalization to make this arm more similar to the other arms.

CAD97 avatar Aug 13 '22 05:08 CAD97

Check failures are

  • unrelated (new clippy warning)
  • spurious docker error?

    docker: Error response from daemon: Duplicate mount point: /home/runner/work/ndarray/ndarray.

CAD97 avatar Aug 13 '22 10:08 CAD97

I'm sorry this has now been conflicted by other changes, so I'll close this for now. I'm not sure about the simplification, the old version makes sure the dimensions are really Ix0 (empty) for the empty slice, and this one doesn't have the same effect? Not sure.

bluss avatar Mar 10 '24 12:03 bluss

It doesn't, tbf. The main reason I made the PR is that $crate in macro patterns is pretty cursed.

CAD97 avatar Mar 10 '24 14:03 CAD97