ndarray-stats icon indicating copy to clipboard operation
ndarray-stats copied to clipboard

bump rand to 0.9.0

Open TD-Sky opened this issue 9 months ago • 2 comments

TD-Sky avatar Feb 25 '25 16:02 TD-Sky

@bluss Would you kindly review and release a new patch version if possible?

TD-Sky avatar Mar 10 '25 05:03 TD-Sky

I did similar changes independently and successfully ran cargo test before checking if a PR was already up.

Some additional things of note that I think should not block merging this, since they are testing or benchmarking related:

  • ndarray-rand, currently with released version 0.15.0, is used for tests. That version of the crate uses rand 0.8, but the version on the main branch already uses 0.9.
    • When a new version of ndarray-rand is released and the version in ndarray-stats is bumped to that, some of the tests and benches need to have the results from Uniform::new handled, I think by just unwrapping.
  • quickcheck version 0.9.2, also for tests, uses rand 0.7. The latest released version 1.0.3 uses rand 0.8. Their current main branch uses 0.9.
    • Bumping quickcheck currently causes some new test failures. Possibly seems like its rummaging through more floating point numbers than previous versions. However, the failures I observed were due to stuff like NaNs, infs, or huge values around 10308.

miikkas avatar Oct 18 '25 16:10 miikkas