ndarray-linalg icon indicating copy to clipboard operation
ndarray-linalg copied to clipboard

Add bounds checks to lax

Open jturner314 opened this issue 3 years ago • 0 comments

For the methods in the lax crate which call LAPACK, we need to either add bounds checks (i.e. checking that the provided layout will not cause an out-of-bounds read for the corresponding slice) or make the methods unsafe.

My preference would actually be to change the API, introducing LapackArrayView and LapackArrayViewMut types which combine the layout and slice together into a single type and have checked conversions from ndarray::ArrayBase.

jturner314 avatar May 20 '21 19:05 jturner314