ndarray-linalg icon indicating copy to clipboard operation
ndarray-linalg copied to clipboard

Added eigg function which is a wrapper to ggev

Open selvavm opened this issue 4 years ago • 3 comments

This is to resolve #267. It is equivalent of eig(A,B) in Matlab

selvavm avatar Apr 18 '21 18:04 selvavm

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a561e5a). Click here to learn what that means. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #280   +/-   ##
=========================================
  Coverage          ?   88.86%           
=========================================
  Files             ?       71           
  Lines             ?     3727           
  Branches          ?        0           
=========================================
  Hits              ?     3312           
  Misses            ?      415           
  Partials          ?        0           
Impacted Files Coverage Δ
lax/src/eig.rs 84.72% <81.66%> (ø)
ndarray-linalg/src/eig.rs 81.81% <100.00%> (ø)
ndarray-linalg/tests/eig.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a561e5a...2d6ab5f. Read the comment docs.

codecov[bot] avatar Apr 18 '21 18:04 codecov[bot]

@termoshtt - could you please review this?

selvavm avatar Apr 19 '21 14:04 selvavm

@termoshtt - I noticed that eigh is using (a,b).eigh() and my implementation is a.eigg(&b). For the former there is no documentation, so it is hard to find.

I can change my implementation to be consistent with it. That is change mine to (a,b).eig(). How do you prefer?

selvavm avatar Apr 25 '21 05:04 selvavm