ndarray-linalg icon indicating copy to clipboard operation
ndarray-linalg copied to clipboard

Skip eigenvector calculation when only eigenvalues are requested

Open SolidTux opened this issue 5 years ago • 3 comments

This disables the eigenvector calculation when only eigenvalues are requested. From my tests this yields the same results and is much faster. (See also #255)

SolidTux avatar Sep 16 '20 13:09 SolidTux

Codecov Report

Merging #256 (b38e324) into master (a561e5a) will decrease coverage by 1.98%. The diff coverage is 26.71%.

:exclamation: Current head b38e324 differs from pull request most recent head c551315. Consider uploading reports for the commit c551315 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   89.01%   87.02%   -1.99%     
==========================================
  Files          71       71              
  Lines        3577     3707     +130     
==========================================
+ Hits         3184     3226      +42     
- Misses        393      481      +88     
Impacted Files Coverage Δ
lax/src/eigh.rs 51.00% <0.00%> (-43.24%) :arrow_down:
lax/src/lib.rs 54.16% <0.00%> (-45.84%) :arrow_down:
ndarray-linalg/src/eigh.rs 50.54% <4.87%> (-41.29%) :arrow_down:
ndarray-linalg/src/eig.rs 100.00% <100.00%> (+33.33%) :arrow_up:
ndarray-linalg/src/solve.rs 72.65% <100.00%> (+0.07%) :arrow_up:
ndarray-linalg/src/solveh.rs 73.26% <100.00%> (-0.48%) :arrow_down:
ndarray-linalg/tests/eig.rs 100.00% <100.00%> (ø)
ndarray-linalg/tests/eigh.rs 100.00% <100.00%> (ø)
ndarray-linalg/tests/cholesky.rs 95.91% <0.00%> (-4.09%) :arrow_down:
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a561e5a...c551315. Read the comment docs.

codecov[bot] avatar Sep 16 '20 14:09 codecov[bot]

Sorry for long my absence. I drop this PR from 0.14.0 release because this is not necessary change.

termoshtt avatar Jul 17 '21 09:07 termoshtt

Any updates? Anything you need from my side?

SolidTux avatar Nov 21 '21 18:11 SolidTux