ndarray-linalg icon indicating copy to clipboard operation
ndarray-linalg copied to clipboard

Explicit memory management of working memory

Open termoshtt opened this issue 5 years ago • 3 comments

Resolve #168

Changes

  • Create structs which manages working memory used in LAPACK routines, e.g. EighWork
  • Lapack trait merges *_ traits, e.g. Eigh_
  • Introduce LapackStrict trait for APIs which manage memory strictly.
  • ~~Make submodules in lax, e.g. lax::eigh, private and expose them into lax:: namespace~~ #242

TODO

  • [x] cholesky
  • [ ] eig
  • [x] eigh
  • [ ] least_square
  • [ ] opnorm
  • [ ] qr
  • [ ] solve
  • [ ] solveh
  • [ ] svd
  • [ ] svddc
  • [ ] triangular
  • [ ] tridiagonal

termoshtt avatar Jul 29 '20 13:07 termoshtt

Codecov Report

Merging #241 into master will decrease coverage by 0.70%. The diff coverage is 69.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
- Coverage   89.08%   88.38%   -0.71%     
==========================================
  Files          71       74       +3     
  Lines        3592     3694     +102     
==========================================
+ Hits         3200     3265      +65     
- Misses        392      429      +37     
Impacted Files Coverage Δ
lax/src/cholesky.rs 100.00% <ø> (ø)
lax/src/lib.rs 100.00% <ø> (ø)
lax/src/strict.rs 0.00% <0.00%> (ø)
lax/src/eigh_generalized.rs 47.94% <47.94%> (ø)
lax/src/eigh.rs 100.00% <100.00%> (+5.55%) :arrow_up:
lax/src/traits.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6ab2b48...ba45af3. Read the comment docs.

codecov[bot] avatar Jul 29 '20 18:07 codecov[bot]

Lapack trait merges *_ traits, e.g. Eigh_ Introduce LapackStrict trait for APIs which manage memory strictly.

These should be split into another PR

termoshtt avatar Aug 02 '20 16:08 termoshtt

This can be done without breaking change. I drop this PR from 0.13.0 milestone.

termoshtt avatar Aug 08 '20 08:08 termoshtt

This PR is outdated. Passed to #333

termoshtt avatar Sep 09 '22 04:09 termoshtt