ndk icon indicating copy to clipboard operation
ndk copied to clipboard

Remove `abort_on_panic()` since Rust 1.81?

Open MarijnS95 opened this issue 1 year ago • 0 comments

In https://github.com/rust-mobile/ndk/pull/412 @spencercw neatly added a wrapper to catch panics instead of unsoundly unwinding them across an extern "C" boundary. Rust 1.81 now plugged that hole and always aborts already:

https://blog.rust-lang.org/2024/09/05/Rust-1.81.0.html#abort-on-uncaught-panics-in-extern-c-functions

This should allow us to get rid of the manual catch+abort when our MSRV is 1.81. Unsure if that gets propagated in the same detail to stderr / Android logs though.

MarijnS95 avatar Sep 05 '24 20:09 MarijnS95