android-rs-glue icon indicating copy to clipboard operation
android-rs-glue copied to clipboard

Published 20 hours ago • verified publisher icon rust-mobile

Propagate additional cargo build options

Open staktrace opened this issue 6 years ago • 6 comments

staktrace avatar Mar 06 '19 16:03 staktrace

Mostly I'm interested in --frozen but I figured I'd do the rest as well.

staktrace avatar Mar 06 '19 16:03 staktrace

(Note that the circleci failure happens on the master branch too)

staktrace avatar Mar 06 '19 21:03 staktrace

Updated PR to actually properly propagate the subcommand arguments along to cargo, which it wasn't doing before.

staktrace avatar Mar 22 '19 05:03 staktrace

Review ping?

jrmuizel avatar Jul 18 '19 20:07 jrmuizel

cc @mb64

goddessfreya avatar Jul 18 '19 21:07 goddessfreya

I tried this out with a simple --color never just to make sure it works, and while it no longer complains about Found argument '--color' which wasn't expected, or isn't valid in this context, the Cargo output was as colorful as ever. It seems that while the arguments are parsed correctly, they aren't getting propagated to the cargo process.

mb64 avatar Jul 23 '19 16:07 mb64