linfa icon indicating copy to clipboard operation
linfa copied to clipboard

Support ndarray 0.16

Open joelchen opened this issue 1 year ago • 10 comments

If project uses ndarray 0.16, the following error occurs when initializing DatasetBase:

the trait `Records` is not implemented for `ArrayBase<OwnedRepr<f64>, Dim<[usize; 2]>>`

joelchen avatar Aug 08 '24 15:08 joelchen

any hope for support 0.16?

altunenes avatar Aug 19 '24 11:08 altunenes

if you clone the repo, just bump up ndarray to "0.16" and linfa-linalg = "0.2". that's how i got this to work

infosechoudini avatar Sep 03 '24 13:09 infosechoudini

@YuhanLiin Noticed you have recently updated linfa-linalg to 0.2. Will updating linfa's ndarray to 0.16 break anything? If not, can you submit a pull request to update ndarray to 0.16?

joelchen avatar Sep 13 '24 18:09 joelchen

It does break some stuff, i had to update linfa to ndarray and then update ndarray-csv (on my github). linfa-linalg to v0.2 and ndarray-linalg are mutually exclusive, so i had to make changes there too. It's quite involved, easy code changes but many locations.

infosechoudini avatar Sep 22 '24 17:09 infosechoudini

I no longer maintain Linfa, but if someone uploads a PR for bumping ndarray I can review and merge it.

YuhanLiin avatar Sep 22 '24 22:09 YuhanLiin

Does anyone maintain Linfa?

infosechoudini avatar Sep 22 '24 22:09 infosechoudini

I might be interested in giving it a look if nobody is working on it. @infosechoudini @YuhanLiin

Mountagha avatar Sep 24 '24 15:09 Mountagha

@superhedge22 Noticed your fork of linfa has updated ndarray to 0.16 from a search on GitHub, can you submit a PR if everything goes well?

joelchen avatar Dec 03 '24 14:12 joelchen

For those watching this, it appears this is being worked on in https://github.com/rust-ml/linfa/pull/371 🎉

jonhoo avatar Mar 03 '25 12:03 jonhoo

For those watching this, it appears this is being worked on in #371 🎉

exciting news! <3

altunenes avatar Mar 03 '25 12:03 altunenes

So, when will it be released? Today is August 3.

xum001 avatar Aug 13 '25 14:08 xum001