linfa icon indicating copy to clipboard operation
linfa copied to clipboard

Add bernoulli naive bayes implementation

Open bytesnake opened this issue 3 years ago • 3 comments

Continuation of https://github.com/rust-ml/linfa/pull/226

bytesnake avatar Aug 30 '22 08:08 bytesnake

error: package time v0.3.14 cannot be built because it requires rustc 1.59.0 or newer, while the currently active rustc version is 1.57.0

not sure which dependency causes this issue

bytesnake avatar Aug 30 '22 08:08 bytesnake

Codecov Report

Base: 55.59% // Head: 55.52% // Decreases project coverage by -0.06% :warning:

Coverage data is based on head (639ccd3) compared to base (d3464d7). Patch coverage: 56.93% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   55.59%   55.52%   -0.07%     
==========================================
  Files          96       98       +2     
  Lines        8951     9042      +91     
==========================================
+ Hits         4976     5021      +45     
- Misses       3975     4021      +46     
Impacted Files Coverage Δ
algorithms/linfa-bayes/src/base_nb.rs 60.00% <ø> (-6.67%) :arrow_down:
algorithms/linfa-bayes/src/hyperparams.rs 9.52% <12.00%> (-1.01%) :arrow_down:
algorithms/linfa-bayes/src/bernoulli_nb.rs 64.28% <64.28%> (ø)
algorithms/linfa-bayes/src/lib.rs 65.38% <65.38%> (ø)
algorithms/linfa-bayes/src/multinomial_nb.rs 67.21% <76.92%> (+3.35%) :arrow_up:
algorithms/linfa-bayes/src/gaussian_nb.rs 62.88% <100.00%> (ø)
...rithms/linfa-trees/src/decision_trees/algorithm.rs 48.26% <0.00%> (-1.57%) :arrow_down:
algorithms/linfa-nn/src/kdtree.rs 48.64% <0.00%> (-1.36%) :arrow_down:
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Aug 30 '22 08:08 codecov-commenter

Seems like we need to bump MSRV to 1.59 (or limit the time dependency to a lower version)

YuhanLiin avatar Sep 02 '22 03:09 YuhanLiin