linfa icon indicating copy to clipboard operation
linfa copied to clipboard

PCA works only for f64

Open jorgehermo9 opened this issue 1 year ago • 3 comments

PCA algorithm is only implemented for f64. Is there a reason for this? Can't it be implemented for trait Float?

jorgehermo9 avatar Jul 29 '22 09:07 jorgehermo9

I can take look at this over the next few days if no one else wants too

EricTulowetzke avatar Aug 03 '22 05:08 EricTulowetzke

Depends on https://github.com/rust-ndarray/ndarray-linalg/pull/275, this is already possible in the native Rust implementation but for fast LAPACK not yet

bytesnake avatar Aug 03 '22 07:08 bytesnake

While the f32 impl would be broken when we use LAPACK, by default we use the pure-Rust linalg library instead, so f32 should work. I'll see if I can enable f32 for the pure-Rust library only without too much copypaste.

YuhanLiin avatar Aug 04 '22 19:08 YuhanLiin