linfa icon indicating copy to clipboard operation
linfa copied to clipboard

Bootstrap Aggregation

Open jk1015 opened this issue 2 years ago • 3 comments

Following on from the discussion in issue #199 here is an implementation of Bootstrap Aggregation following the approach laid out there. There is also an example showing how the provided methods can be used together with the existing linfa-trees package to implement a Random Forest.

Outside of the linfa-ensemble package the only required change was to factor the trait FromTargetArray to create an additional trait FromTargetArrayOwned. This was done to allow owned data to be used without needing to specify a lifetime, which was impossible under the previous FromTargetArray trait.

jk1015 avatar Jul 07 '22 13:07 jk1015

Codecov Report

Base: 55.44% // Head: 55.11% // Decreases project coverage by -0.33% :warning:

Coverage data is based on head (46722ec) compared to base (d4bd9c9). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
- Coverage   55.44%   55.11%   -0.34%     
==========================================
  Files          95       97       +2     
  Lines        8774     9014     +240     
==========================================
+ Hits         4865     4968     +103     
- Misses       3909     4046     +137     
Impacted Files Coverage Δ
algorithms/linfa-ensemble/src/ensemble.rs 0.00% <0.00%> (ø)
src/dataset/impl_dataset.rs 41.95% <ø> (ø)
src/dataset/impl_targets.rs 21.31% <ø> (ø)
src/dataset/mod.rs 87.93% <ø> (-1.04%) :arrow_down:
algorithms/linfa-trees/src/decision_trees/iter.rs 0.00% <0.00%> (-25.00%) :arrow_down:
...thms/linfa-trees/src/decision_trees/hyperparams.rs 19.56% <0.00%> (-6.53%) :arrow_down:
algorithms/linfa-linear/src/glm/mod.rs 55.55% <0.00%> (-2.99%) :arrow_down:
algorithms/linfa-kernel/src/lib.rs 61.39% <0.00%> (-1.88%) :arrow_down:
...lgorithms/linfa-clustering/src/optics/algorithm.rs 48.57% <0.00%> (-1.73%) :arrow_down:
...rithms/linfa-clustering/src/k_means/hyperparams.rs 43.33% <0.00%> (-1.67%) :arrow_down:
... and 40 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Jul 16 '22 06:07 codecov-commenter

Hi! Could you please guide me as to what is remaining in this? Thank You!

HridayM25 avatar Mar 21 '23 10:03 HridayM25

Merge/rebase with the latest master and address the open review comments. That's pretty much it.

YuhanLiin avatar Mar 22 '23 00:03 YuhanLiin